From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Ntd9B-0004Po-MI for qemu-devel@nongnu.org; Mon, 22 Mar 2010 04:38:05 -0400 Received: from [199.232.76.173] (port=49985 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Ntd9A-0004PD-2C for qemu-devel@nongnu.org; Mon, 22 Mar 2010 04:38:04 -0400 Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim 4.60) (envelope-from ) id 1Ntd99-00048L-9G for qemu-devel@nongnu.org; Mon, 22 Mar 2010 04:38:03 -0400 Received: from mail-gw0-f45.google.com ([74.125.83.45]:61691) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1Ntd98-00048H-VZ for qemu-devel@nongnu.org; Mon, 22 Mar 2010 04:38:03 -0400 Received: by gwb11 with SMTP id 11so1328359gwb.4 for ; Mon, 22 Mar 2010 01:38:02 -0700 (PDT) Date: Mon, 22 Mar 2010 16:36:56 +0800 From: Bruce Majia Subject: Re: [Qemu-devel] Build always fail on x86_32 host for i386_softmmu target Message-ID: <20100322083656.GA5656@localhost> References: <20100322061658.GC20376@localhost> <4BA72ACD.8030008@mail.berlios.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4BA72ACD.8030008@mail.berlios.de> Reply-To: Bruce Majia List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Weil Cc: qemu-devel@nongnu.org On Mon, Mar 22, 2010 at 09:31:09AM +0100, Stefan Weil wrote: > Bruce Majia schrieb: > > Hi, > > > > When I built qemu on my x86_32 host with following configure line: > > > > $ ./configure --prefix=/usr/local/qemus/master \ > > --target-list=i386-softmmu > > $ make > > > > The build will always fail with message: > > ---------------------------------------- > > ... > > CC i386-softmmu/fpu/softfloat-native.o > > /mnt/farm/my_repo/qemu/fpu/softfloat-native.c:130:5: error: > > "HOST_LONG_BITS" is not defined > > make[1]: *** [fpu/softfloat-native.o] Error 1 > > make: *** [subdir-i386-softmmu] Error 2 > > ---------------------------------------- > > > > Is this a known issue or something wrong with my configure line? > > > > Though I can make it work with a minor nasty patch: > > ============== > > diff --git a/fpu/softfloat-native.c b/fpu/softfloat-native.c > > index 049c830..5ba5013 100644 > > --- a/fpu/softfloat-native.c > > +++ b/fpu/softfloat-native.c > > @@ -127,6 +127,9 @@ floatx80 int64_to_floatx80( int64_t v STATUS_PARAM) > > #endif > > > > /* XXX: this code implements the x86 behaviour, not the IEEE one. */ > > +#ifndef HOST_LONG_BITS > > +#define HOST_LONG_BITS 32 > > +#endif > > #if HOST_LONG_BITS == 32 > > static inline int long_to_int32(long a) > > { > > ============== > > > > I thought it may necessary to ask if something wrong with above hack. > > And can we get the problem fixed properly? > > > > Thanks. > > -b > > I had this problem with incremental builds several times, too. > A new make from scratch (all generated files removed) always worked, > so I don't think your patch is needed. Yes, you are right. I must messed up several incremental builds and clean build. While I just tried clean configure and build, I just got warning like this: fpu/softfloat-native.c:132:5: warning: "HOST_LONG_BITS" is not defined That is fine to me. Though it would be better to avoid the warning. :) Thanks. -b