From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NuBeX-0000cn-Nh for qemu-devel@nongnu.org; Tue, 23 Mar 2010 17:28:45 -0400 Received: from [140.186.70.92] (port=40838 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NuBeS-0000Zi-V7 for qemu-devel@nongnu.org; Tue, 23 Mar 2010 17:28:45 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1NuBeQ-0001oA-TX for qemu-devel@nongnu.org; Tue, 23 Mar 2010 17:28:40 -0400 Received: from hall.aurel32.net ([88.191.82.174]:51474) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1NuBeQ-0001o6-OF for qemu-devel@nongnu.org; Tue, 23 Mar 2010 17:28:38 -0400 Date: Tue, 23 Mar 2010 22:28:36 +0100 From: Aurelien Jarno Subject: Re: [Qemu-devel] [PATCH 3/4] tcg-hppa: Finish the port. Message-ID: <20100323212836.GC19086@hall.aurel32.net> References: <6880f84577b97d0334b95f6ce031e61c65c2e88b.1268754659.git.rth@twiddle.net> <20100317015829.GC23195@zubnet.me.uk> <4BA0ED8C.8000404@twiddle.net> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Disposition: inline In-Reply-To: <4BA0ED8C.8000404@twiddle.net> Sender: Aurelien Jarno List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Richard Henderson Cc: Stuart Brady , qemu-devel@nongnu.org On Wed, Mar 17, 2010 at 07:56:12AM -0700, Richard Henderson wrote: > On 03/16/2010 06:58 PM, Stuart Brady wrote: > > The tcg_reg_free() calls worry me slightly, but I assume they're safe... > > Yeah, that one's rather gross. > > Since Aurelien's generic div/rem patch I could simply remove all > that millicode stuff, including that tcg_reg_free, and let the > generic code handle this instead. Which would get to the same > millicode routine via one or two extra levels of indirection. > > Thoughts? > I think that's the way to go. Can you please send a new patch doing that? -- Aurelien Jarno GPG: 1024D/F1BCDB73 aurelien@aurel32.net http://www.aurel32.net