From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1NuW8k-0003do-R9
	for qemu-devel@nongnu.org; Wed, 24 Mar 2010 15:21:18 -0400
Received: from [140.186.70.92] (port=56491 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1NuW8j-0003dB-Jw
	for qemu-devel@nongnu.org; Wed, 24 Mar 2010 15:21:18 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69)
	(envelope-from <lcapitulino@redhat.com>) id 1NuW8i-0006Rw-28
	for qemu-devel@nongnu.org; Wed, 24 Mar 2010 15:21:17 -0400
Received: from mx1.redhat.com ([209.132.183.28]:25912)
	by eggs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <lcapitulino@redhat.com>) id 1NuW8h-0006Rg-OJ
	for qemu-devel@nongnu.org; Wed, 24 Mar 2010 15:21:15 -0400
Received: from int-mx03.intmail.prod.int.phx2.redhat.com
	(int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.16])
	by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o2OJLEce029523
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)
	for <qemu-devel@nongnu.org>; Wed, 24 Mar 2010 15:21:15 -0400
Date: Wed, 24 Mar 2010 16:20:53 -0300
From: Luiz Capitulino <lcapitulino@redhat.com>
Message-ID: <20100324162053.55699d24@redhat.com>
In-Reply-To: <1269340078-16446-1-git-send-email-armbru@redhat.com>
References: <1269340078-16446-1-git-send-email-armbru@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] Re: [PATCH 0/4] monitor: Convert do_set_link() to
	QObject, QError
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Markus Armbruster <armbru@redhat.com>
Cc: qemu-devel@nongnu.org

On Tue, 23 Mar 2010 11:27:54 +0100
Markus Armbruster <armbru@redhat.com> wrote:

> PATCH 3/4 changes syntax of set_link's second argument from up|down to
> on|off.  I feel that the argument needs to be boolean in QMP, and this
> is the simplest way to get it.
> 
> Alternatives I could try if the syntax change is unwanted:
> 
> * Use the old string argument in QMP.  Easy.
> 
> * Don't convert set_link, create a new command with a boolean
>   argument.
> 
> * Create a argument parser for up|down.

 I like your approach. Daniel do you use set_link in libvirt already?
I've grepped around I didn't found any reference for it.

> 
> Markus Armbruster (4):
>   monitor: Rename argument type 'b' to 'f'
>   monitor: New argument type 'b'
>   monitor: Use argument type 'b' for set_link
>   monitor: Convert do_set_link() to QObject, QError
> 
>  monitor.c       |   39 +++++++++++++++++++++++++++++++++++----
>  net.c           |   17 ++++++-----------
>  net.h           |    2 +-
>  qemu-monitor.hx |   13 +++++++------
>  4 files changed, 49 insertions(+), 22 deletions(-)
>