From: Luiz Capitulino <lcapitulino@redhat.com>
To: Markus Armbruster <armbru@redhat.com>
Cc: aurelien@aurel32.net, Amos Kong <akong@redhat.com>,
qemu-devel@nongnu.org, kvm@vger.kernel.org,
Richard Henderson <rth@twiddle.net>
Subject: Re: [Qemu-devel] [PATCH] qemu: jaso-parser: Output the content of invalid keyword
Date: Wed, 24 Mar 2010 17:38:02 -0300 [thread overview]
Message-ID: <20100324173802.58186de2@redhat.com> (raw)
In-Reply-To: <m3sk7pzp4h.fsf@blackfin.pond.sub.org>
On Wed, 24 Mar 2010 17:00:14 +0100
Markus Armbruster <armbru@redhat.com> wrote:
> Amos Kong <akong@redhat.com> writes:
>
> > When input some invialid word 'unknowcmd' through QMP port, qemu outputs this
> > error message:
> > "parse error: invalid keyword `%s'"
> > This patch makes qemu output the content of invalid keyword, like:
> > "parse error: invalid keyword `unknowcmd'"
> >
> > Signed-off-by: Amos Kong <akong@redhat.com>
>
> Looks good to me.
>
> Hint: it's best to put a version in the subject when you respin, like
> [PATCH v2] ...
Yes, and maintainers may miss a patch down a thread (and it's a good
opportunity to fix the subject).
next prev parent reply other threads:[~2010-03-24 20:38 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-24 12:17 [Qemu-devel] [PATCH][RESEND] qemu: jaso-parser: Output the content of invalid keyword Amos Kong
2010-03-24 12:21 ` Richard Henderson
2010-03-24 15:12 ` [Qemu-devel] [PATCH] " Amos Kong
2010-03-24 16:00 ` Markus Armbruster
2010-03-24 20:38 ` Luiz Capitulino [this message]
2010-03-24 17:25 ` [Qemu-devel] " Richard Henderson
-- strict thread matches above, loose matches on Subject: below --
2010-03-27 12:52 [Qemu-devel] " Aurelien Jarno
[not found] <1269424853-15386-1-git-send-email-akong@redhat.com>
[not found] ` <20100324102940.GA22874@hall.aurel32.net>
2010-03-24 11:34 ` Amos Kong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100324173802.58186de2@redhat.com \
--to=lcapitulino@redhat.com \
--cc=akong@redhat.com \
--cc=armbru@redhat.com \
--cc=aurelien@aurel32.net \
--cc=kvm@vger.kernel.org \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).