From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1Nursp-0003rR-HH
	for qemu-devel@nongnu.org; Thu, 25 Mar 2010 14:34:19 -0400
Received: from [140.186.70.92] (port=40353 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1Nursn-0003qC-PZ
	for qemu-devel@nongnu.org; Thu, 25 Mar 2010 14:34:18 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69)
	(envelope-from <lcapitulino@redhat.com>) id 1Nursm-0001q4-0x
	for qemu-devel@nongnu.org; Thu, 25 Mar 2010 14:34:17 -0400
Received: from mx1.redhat.com ([209.132.183.28]:34155)
	by eggs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <lcapitulino@redhat.com>) id 1Nursl-0001py-O8
	for qemu-devel@nongnu.org; Thu, 25 Mar 2010 14:34:15 -0400
Received: from int-mx05.intmail.prod.int.phx2.redhat.com
	(int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.18])
	by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o2PIYEBt027345
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)
	for <qemu-devel@nongnu.org>; Thu, 25 Mar 2010 14:34:14 -0400
Date: Thu, 25 Mar 2010 15:34:06 -0300
From: Luiz Capitulino <lcapitulino@redhat.com>
Message-ID: <20100325153406.69fbc717@redhat.com>
In-Reply-To: <20100325034717.GA23562@amit-x200.redhat.com>
References: <1269442173-18421-3-git-send-email-amit.shah@redhat.com>
	<1269442173-18421-4-git-send-email-amit.shah@redhat.com>
	<1269442173-18421-5-git-send-email-amit.shah@redhat.com>
	<1269442173-18421-6-git-send-email-amit.shah@redhat.com>
	<1269442173-18421-7-git-send-email-amit.shah@redhat.com>
	<1269442173-18421-8-git-send-email-amit.shah@redhat.com>
	<1269442173-18421-9-git-send-email-amit.shah@redhat.com>
	<1269442173-18421-10-git-send-email-amit.shah@redhat.com>
	<1269442173-18421-11-git-send-email-amit.shah@redhat.com>
	<20100324173415.63e31bd0@redhat.com>
	<20100325034717.GA23562@amit-x200.redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] Re: [PATCH 10/15] virtio-serial: Add QMP events for
 failed port/device add
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Amit Shah <amit.shah@redhat.com>
Cc: Juan Quintela <quintela@redhat.com>, Gerd Hoffmann <kraxel@redhat.com>, qemu list <qemu-devel@nongnu.org>, "Michael S. Tsirkin" <mst@redhat.com>

On Thu, 25 Mar 2010 09:17:17 +0530
Amit Shah <amit.shah@redhat.com> wrote:

> On (Wed) Mar 24 2010 [17:34:15], Luiz Capitulino wrote:
> > On Wed, 24 Mar 2010 20:19:28 +0530
> > Amit Shah <amit.shah@redhat.com> wrote:
> > 
> > > When adding a port or a device to the guest fails, management software
> > > might be interested in knowing and then cleaning up the host-side of the
> > > port. Introduce QMP events to signal such errors.
> > 
> >  I'm completely unfamiliar with virtio-serial, so let me ask: how are ports
> > added? I'd expect the command performing this operation to fail in this case.
> 
> If adding the port fails in qemu, then the command will fail. However if
> adding the port in the guest fails, we raise this QMP event. Adding in
> the guest could fail because of several reasons, like ENOMEM. In this
> case, the mgmt might want to hot-unplug the port from qemu so that
> resources are freed and also apps are notified of guest side not ready.

 Ok, what about a disconnect? Does virtio-serial have this kind of action?