[Qemu-devel] Re: [PATCH 10/15] virtio-serial: Add QMP events for failed port/device add

[Luiz Capitulino <lcapitulino@redhat.com>]

On Wed, 24 Mar 2010 20:19:28 +0530
Amit Shah <amit.shah@redhat.com> wrote:

> When adding a port or a device to the guest fails, management software
> might be interested in knowing and then cleaning up the host-side of the
> port. Introduce QMP events to signal such errors.
> 
> Signed-off-by: Amit Shah <amit.shah@redhat.com>
> CC: Luiz Capitulino <lcapitulino@redhat.com>
> ---
>  QMP/qmp-events.txt     |   48 ++++++++++++++++++++++++++++++++++++++++++++++++
>  hw/virtio-serial-bus.c |   15 +++++++++++++++
>  monitor.c              |    3 +++
>  monitor.h              |    1 +
>  4 files changed, 67 insertions(+), 0 deletions(-)
> 
> diff --git a/QMP/qmp-events.txt b/QMP/qmp-events.txt
> index a94e9b4..f13cf45 100644
> --- a/QMP/qmp-events.txt
> +++ b/QMP/qmp-events.txt
> @@ -188,3 +188,51 @@ Example:
>  
>  Note: If action is "reset", "shutdown", or "pause" the WATCHDOG event is
>  followed respectively by the RESET, SHUTDOWN, or STOP events.
> +
> +VIRTIO_SERIAL
> +-------------

 It should be VIRTIO_SERIAL_ADD.

> +
> +Emitted when errors occur in guest port add or guest device add.
> +
> +Data:
> +
> +- "device": The virtio-serial device that triggered the event {json-string}
> +      This is the name given to the bus on the command line:
> +        -device virtio-serial,id="foo"
> +      here, the device name is "foo"
> +
> +- "port": The port number that triggered the event {json-number}
> +      This is the number given to the port on the command line:
> +        -device virtserialport,nr=2
> +      here, the port number is 2. If not mentioned on the command
> +      line, the number is auto-assigned.

 We use (json-number) instead of {json-number}.

> +
> +- "result": The result of the operation {json-string}
> +      This is one of the following:
> +         "pass", "fail"

 "result" could be a boolean "success".

> +
> +- "operation": The operation that triggered the event {json-sring}
> +      This is one of the following:
> +         "port_add", "device_add"

 You can drop the '_add', as this information is in the event name.

> +
> +Example:
> +
> +Port 0 add failure in the guest:
> +
> +{ "timestamp": {"seconds": 1269438649, "microseconds": 851170},
> +  "event": "VIRTIO_SERIAL",
> +  "data": {
> +            "device": "virtio-serial-bus.0",
> +            "port": 0,
> +            "result": "fail",
> +            "operation": "port_add" } }

 If you look at the other events you will see that I put the event
first and the timestamp later, I know this is not how the event is
going to be on the wire but improves the readability of this file
(and the spec says that clients should not assume the ordering of
dicts or lists).

 Implementation looks ok.