From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1Nur30-0006b2-HU
	for qemu-devel@nongnu.org; Thu, 25 Mar 2010 13:40:46 -0400
Received: from [140.186.70.92] (port=49347 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1Nur2y-0006Vs-2h
	for qemu-devel@nongnu.org; Thu, 25 Mar 2010 13:40:45 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69)
	(envelope-from <berrange@redhat.com>) id 1Nur2o-0004DT-Du
	for qemu-devel@nongnu.org; Thu, 25 Mar 2010 13:40:40 -0400
Received: from mx1.redhat.com ([209.132.183.28]:41877)
	by eggs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <berrange@redhat.com>) id 1Nur2o-0004DG-6W
	for qemu-devel@nongnu.org; Thu, 25 Mar 2010 13:40:34 -0400
Received: from int-mx04.intmail.prod.int.phx2.redhat.com
	(int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.17])
	by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o2PHeWkH020349
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)
	for <qemu-devel@nongnu.org>; Thu, 25 Mar 2010 13:40:33 -0400
Date: Thu, 25 Mar 2010 17:40:30 +0000
From: "Daniel P. Berrange" <berrange@redhat.com>
Message-ID: <20100325174030.GW10705@redhat.com>
References: <1269340078-16446-1-git-send-email-armbru@redhat.com>
	<20100324162053.55699d24@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20100324162053.55699d24@redhat.com>
Subject: [Qemu-devel] Re: [PATCH 0/4] monitor: Convert do_set_link() to
	QObject, QError
Reply-To: "Daniel P. Berrange" <berrange@redhat.com>
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Luiz Capitulino <lcapitulino@redhat.com>
Cc: Markus Armbruster <armbru@redhat.com>, qemu-devel@nongnu.org

On Wed, Mar 24, 2010 at 04:20:53PM -0300, Luiz Capitulino wrote:
> On Tue, 23 Mar 2010 11:27:54 +0100
> Markus Armbruster <armbru@redhat.com> wrote:
> 
> > PATCH 3/4 changes syntax of set_link's second argument from up|down to
> > on|off.  I feel that the argument needs to be boolean in QMP, and this
> > is the simplest way to get it.
> > 
> > Alternatives I could try if the syntax change is unwanted:
> > 
> > * Use the old string argument in QMP.  Easy.
> > 
> > * Don't convert set_link, create a new command with a boolean
> >   argument.
> > 
> > * Create a argument parser for up|down.
> 
>  I like your approach. Daniel do you use set_link in libvirt already?
> I've grepped around I didn't found any reference for it.

We don't currently use it, but plan to in the not too distant future.

Regards,
Daniel
-- 
|: Red Hat, Engineering, London    -o-   http://people.redhat.com/berrange/ :|
|: http://libvirt.org -o- http://virt-manager.org -o- http://deltacloud.org :|
|: http://autobuild.org        -o-         http://search.cpan.org/~danberr/ :|
|: GnuPG: 7D3B9505  -o-   F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|