From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Nuy3M-0003Zy-Hv for qemu-devel@nongnu.org; Thu, 25 Mar 2010 21:09:36 -0400 Received: from [140.186.70.92] (port=34305 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Nuy3J-0003Zp-1S for qemu-devel@nongnu.org; Thu, 25 Mar 2010 21:09:35 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1Nuy3H-0003Oy-M4 for qemu-devel@nongnu.org; Thu, 25 Mar 2010 21:09:32 -0400 Received: from mail2.shareable.org ([80.68.89.115]:50570) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Nuy3H-0003O5-Go for qemu-devel@nongnu.org; Thu, 25 Mar 2010 21:09:31 -0400 Date: Fri, 26 Mar 2010 01:09:23 +0000 From: Jamie Lokier Subject: Re: [Qemu-devel] [PATCH 02/15] virtio-serial: save/load: Ensure nr_ports on src and dest are same. Message-ID: <20100326010923.GD19308@shareable.org> References: <1269442173-18421-1-git-send-email-amit.shah@redhat.com> <1269442173-18421-2-git-send-email-amit.shah@redhat.com> <1269442173-18421-3-git-send-email-amit.shah@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1269442173-18421-3-git-send-email-amit.shah@redhat.com> List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Amit Shah Cc: "Michael S. Tsirkin" , Gerd Hoffmann , qemu list , Juan Quintela Amit Shah wrote: > The number of ports on the source as well as the destination machines > should match. If they don't, it means some ports that got hotplugged on > the source aren't instantiated on the destination. Or that ports that > were hot-unplugged on the source are created on the destination. Surely the set of guest-visible ids must match exactly and be checked (maybe mapped, if they were given in a different order), in which case counting the number of ports looks redundant. I.e. is this check hiding the omission of the proper one? -- Jamie