From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1NuyvI-0005sx-3T
	for qemu-devel@nongnu.org; Thu, 25 Mar 2010 22:05:20 -0400
Received: from [140.186.70.92] (port=53122 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1NuyvD-0005s9-0K
	for qemu-devel@nongnu.org; Thu, 25 Mar 2010 22:05:19 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69)
	(envelope-from <amit.shah@redhat.com>) id 1NuyuU-00008m-9F
	for qemu-devel@nongnu.org; Thu, 25 Mar 2010 22:04:31 -0400
Received: from mx1.redhat.com ([209.132.183.28]:6542)
	by eggs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <amit.shah@redhat.com>) id 1NuyuU-00008W-1E
	for qemu-devel@nongnu.org; Thu, 25 Mar 2010 22:04:30 -0400
Date: Fri, 26 Mar 2010 07:33:01 +0530
From: Amit Shah <amit.shah@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 02/15] virtio-serial: save/load: Ensure
	nr_ports on src and dest are same.
Message-ID: <20100326020301.GG8111@amit-x200.redhat.com>
References: <1269442173-18421-1-git-send-email-amit.shah@redhat.com>
	<1269442173-18421-2-git-send-email-amit.shah@redhat.com>
	<1269442173-18421-3-git-send-email-amit.shah@redhat.com>
	<20100326010923.GD19308@shareable.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20100326010923.GD19308@shareable.org>
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Jamie Lokier <jamie@shareable.org>
Cc: qemu list <qemu-devel@nongnu.org>, Juan Quintela <quintela@redhat.com>, Gerd Hoffmann <kraxel@redhat.com>, "Michael S. Tsirkin" <mst@redhat.com>

On (Fri) Mar 26 2010 [01:09:23], Jamie Lokier wrote:
> Amit Shah wrote:
> > The number of ports on the source as well as the destination machines
> > should match. If they don't, it means some ports that got hotplugged on
> > the source aren't instantiated on the destination. Or that ports that
> > were hot-unplugged on the source are created on the destination.
> 
> Surely the set of guest-visible ids must match exactly and be checked
> (maybe mapped, if they were given in a different order), in which case
> counting the number of ports looks redundant.
> 
> I.e. is this check hiding the omission of the proper one?

Yes, That's added in a later patch (5). That patch changes the guest
abi, so it's separate.

Also, patch 3 checks if all the ports on the src are present on the
dest.

		Amit