From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1NvAXK-0001C3-6z
	for qemu-devel@nongnu.org; Fri, 26 Mar 2010 10:29:22 -0400
Received: from [140.186.70.92] (port=35527 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1NvAXF-0001AE-5x
	for qemu-devel@nongnu.org; Fri, 26 Mar 2010 10:29:21 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69)
	(envelope-from <lcapitulino@redhat.com>) id 1NvAXD-0000kI-Ri
	for qemu-devel@nongnu.org; Fri, 26 Mar 2010 10:29:17 -0400
Received: from mx1.redhat.com ([209.132.183.28]:37803)
	by eggs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <lcapitulino@redhat.com>) id 1NvAXD-0000jy-JY
	for qemu-devel@nongnu.org; Fri, 26 Mar 2010 10:29:15 -0400
Date: Fri, 26 Mar 2010 11:29:03 -0300
From: Luiz Capitulino <lcapitulino@redhat.com>
Subject: Re: [Qemu-devel] Re: [PATCH 10/15] virtio-serial: Add QMP events
	for failed port/device add
Message-ID: <20100326112903.712262b9@redhat.com>
In-Reply-To: <20100326132620.GE7039@amit-x200.redhat.com>
References: <1269442173-18421-5-git-send-email-amit.shah@redhat.com>
	<1269442173-18421-6-git-send-email-amit.shah@redhat.com>
	<1269442173-18421-7-git-send-email-amit.shah@redhat.com>
	<1269442173-18421-8-git-send-email-amit.shah@redhat.com>
	<1269442173-18421-9-git-send-email-amit.shah@redhat.com>
	<1269442173-18421-10-git-send-email-amit.shah@redhat.com>
	<1269442173-18421-11-git-send-email-amit.shah@redhat.com>
	<20100325155541.570f817d@redhat.com>
	<20100326021628.GI8111@amit-x200.redhat.com>
	<20100326101402.02e3fffb@redhat.com>
	<20100326132620.GE7039@amit-x200.redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Amit Shah <amit.shah@redhat.com>
Cc: qemu list <qemu-devel@nongnu.org>, aliguori@us.ibm.com, "Michael S. Tsirkin" <mst@redhat.com>, Gerd Hoffmann <kraxel@redhat.com>, Juan Quintela <quintela@redhat.com>

On Fri, 26 Mar 2010 18:56:20 +0530
Amit Shah <amit.shah@redhat.com> wrote:

> On (Fri) Mar 26 2010 [10:14:02], Luiz Capitulino wrote:
> > > > > +
> > > > > +VIRTIO_SERIAL
> > > > > +-------------
> > > > 
> > > >  It should be VIRTIO_SERIAL_ADD.
> > > 
> > > What about other events that VIRTIO_SERIAL generates?
> > 
> >  We don't address this problem currently, maybe an integration with qdev
> > will do, but I have to think more about it.
> 
> So should I just keep it as VIRTIO_SERIAL for now? With new events also
> riding on this one?

 I don't like this because with the current events code this will lead
to confusion, as you're using a single event to notify different things.

 My suggestion for the immediate term is to do what we have been doing so
far, ie. call it VIRTIO_SERIAL_ADD. Worst case here is: we add a new way
to group events which requires a new VIRTIO_SERIAL event, in this case we
could emit both, the new VIRTIO_SERIAL and the old VIRTIO_SERIAL_ADD. The
latter would be deprecated too.

 Or, if you can wait I can _try_ to solve this problem next week, although
I have no idea how hard this is going to be.

 Any comments, Anthony?