From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Nv9Zp-00055U-SK for qemu-devel@nongnu.org; Fri, 26 Mar 2010 09:27:53 -0400 Received: from [140.186.70.92] (port=46099 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Nv9Zo-00055I-Lm for qemu-devel@nongnu.org; Fri, 26 Mar 2010 09:27:53 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1Nv9Zn-000231-Ck for qemu-devel@nongnu.org; Fri, 26 Mar 2010 09:27:52 -0400 Received: from mx1.redhat.com ([209.132.183.28]:6371) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Nv9Zl-00022r-NS for qemu-devel@nongnu.org; Fri, 26 Mar 2010 09:27:50 -0400 Received: from int-mx05.intmail.prod.int.phx2.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.18]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o2QDRmEL003378 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Fri, 26 Mar 2010 09:27:49 -0400 Date: Fri, 26 Mar 2010 18:56:20 +0530 From: Amit Shah Subject: Re: [Qemu-devel] Re: [PATCH 10/15] virtio-serial: Add QMP events for failed port/device add Message-ID: <20100326132620.GE7039@amit-x200.redhat.com> References: <1269442173-18421-5-git-send-email-amit.shah@redhat.com> <1269442173-18421-6-git-send-email-amit.shah@redhat.com> <1269442173-18421-7-git-send-email-amit.shah@redhat.com> <1269442173-18421-8-git-send-email-amit.shah@redhat.com> <1269442173-18421-9-git-send-email-amit.shah@redhat.com> <1269442173-18421-10-git-send-email-amit.shah@redhat.com> <1269442173-18421-11-git-send-email-amit.shah@redhat.com> <20100325155541.570f817d@redhat.com> <20100326021628.GI8111@amit-x200.redhat.com> <20100326101402.02e3fffb@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20100326101402.02e3fffb@redhat.com> List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Luiz Capitulino Cc: qemu list , "Michael S. Tsirkin" , Gerd Hoffmann , Juan Quintela On (Fri) Mar 26 2010 [10:14:02], Luiz Capitulino wrote: > > > > + > > > > +VIRTIO_SERIAL > > > > +------------- > > > > > > It should be VIRTIO_SERIAL_ADD. > > > > What about other events that VIRTIO_SERIAL generates? > > We don't address this problem currently, maybe an integration with qdev > will do, but I have to think more about it. So should I just keep it as VIRTIO_SERIAL for now? With new events also riding on this one? > > Should they have a different event by themselves? > > With the current code, yes. But would be good to avoid it until we have > a proper solution. > > > Or should they ride on top of VIRTIO_SERIAL and mention different > > 'operations' that caused the event? > > I'd prefer having a different name if it's a different event, at least > this is how we've done it so far. Erm, now I'm confused. > > > > + > > > > +- "result": The result of the operation {json-string} > > > > + This is one of the following: > > > > + "pass", "fail" > > > > > > "result" could be a boolean "success". > > > > OK; success/fail? Also, by boolean, do you mean the data type? How is > > that represented? > > In JSON it's true/false. In our parser you can use '%i' with integers, > undocumented, yes, sorry for that. Oh ok; no problem. Amit