From: Paul Brook <paul@codesourcery.com>
To: qemu-devel@nongnu.org
Cc: Riku Voipio <riku.voipio@nokia.com>,
Riku Voipio <riku.voipio@iki.fi>,
Michael Casadevall <mcasadevall@ubuntu.com>
Subject: Re: [Qemu-devel] [PATCH 1/4] linux-user: add pselect syscall
Date: Fri, 26 Mar 2010 23:05:31 +0000 [thread overview]
Message-ID: <201003262305.32156.paul@codesourcery.com> (raw)
In-Reply-To: <f006b92f2656f50808bcb4d7ede5580b1a7ca01a.1269616764.git.riku.voipio@nokia.com>
>This patch adds support for the pselect syscall in linux-user emulation
>and also adds several support functions required to translate the
>timespec structs between the target and the host.
IIUC the whole point of the pselect is that it should be atomic. By emulating
this in a non-atomic fasion I think you're re-introducing the race condition
that it is designed to avoid.
Wouldn't it be better to just return ENOSYS and let the guest deal with the
problem?
Paul
next prev parent reply other threads:[~2010-03-26 23:09 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-26 15:25 [Qemu-devel] [PATCH 0/4] linux-user patches for upstream Riku Voipio
2010-03-26 15:25 ` [Qemu-devel] [PATCH 1/4] linux-user: add pselect syscall Riku Voipio
2010-03-26 15:25 ` [Qemu-devel] [PATCH 2/4] linux-user: Add the syscall id for pselect6 on ARM Riku Voipio
2010-03-26 15:25 ` [Qemu-devel] [PATCH 3/4] Add inotify_init1 syscall support Riku Voipio
2010-03-26 15:25 ` [Qemu-devel] [PATCH 4/4] fix 0 sized write syscall Riku Voipio
2010-03-26 16:07 ` Richard Henderson
2010-03-26 22:14 ` [Qemu-devel] [PATCH 3/4] Add inotify_init1 syscall support Aurelien Jarno
2010-03-26 22:13 ` [Qemu-devel] [PATCH 2/4] linux-user: Add the syscall id for pselect6 on ARM Aurelien Jarno
2010-03-26 22:15 ` [Qemu-devel] [PATCH 1/4] linux-user: add pselect syscall Aurelien Jarno
2010-03-26 23:05 ` Paul Brook [this message]
2010-03-28 18:49 ` Jamie Lokier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201003262305.32156.paul@codesourcery.com \
--to=paul@codesourcery.com \
--cc=mcasadevall@ubuntu.com \
--cc=qemu-devel@nongnu.org \
--cc=riku.voipio@iki.fi \
--cc=riku.voipio@nokia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).