From: Aurelien Jarno <aurelien@aurel32.net>
To: Michael Tokarev <mjt@tls.msk.ru>
Cc: qemu-devel <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [trivial one-liner] be more specific in -mem-path error messages
Date: Sat, 27 Mar 2010 13:33:50 +0100 [thread overview]
Message-ID: <20100327123350.GA19617@volta.aurel32.net> (raw)
In-Reply-To: <4B9F3AEA.8010408@msgid.tls.msk.ru>
On Tue, Mar 16, 2010 at 11:01:46AM +0300, Michael Tokarev wrote:
> The error message qemu gives when hugetlbfs is not
> accessible is cryptic at best:
>
> mkstemp: Permission denied
>
> Make it a bit more specific instead:
>
> unable to create backing store for hugepages: Permission denied
>
> Thanks!
It looks good, but needs a Signed-off-by: line.
> /mjt
>
> diff --git a/exec.c b/exec.c
> index 891e0ee..985bdde 100644
> --- a/exec.c
> +++ b/exec.c
> @@ -2569,5 +2569,5 @@ static void *file_ram_alloc(ram_addr_t memory, const char *path)
> fd = mkstemp(filename);
> if (fd < 0) {
> - perror("mkstemp");
> + perror("unable to create backing store for hugepages");
> free(filename);
> return NULL;
>
>
>
--
Aurelien Jarno GPG: 1024D/F1BCDB73
aurelien@aurel32.net http://www.aurel32.net
next prev parent reply other threads:[~2010-03-27 12:33 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-16 8:01 [Qemu-devel] [trivial one-liner] be more specific in -mem-path error messages Michael Tokarev
2010-03-27 12:33 ` Aurelien Jarno [this message]
2010-03-27 13:35 ` Michael Tokarev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100327123350.GA19617@volta.aurel32.net \
--to=aurelien@aurel32.net \
--cc=mjt@tls.msk.ru \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).