From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1NvVD9-0002we-2z
	for qemu-devel@nongnu.org; Sat, 27 Mar 2010 08:33:55 -0400
Received: from [140.186.70.92] (port=48130 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1NvVD7-0002vH-8C
	for qemu-devel@nongnu.org; Sat, 27 Mar 2010 08:33:54 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69)
	(envelope-from <aurelien@aurel32.net>) id 1NvVD5-0001Yc-SU
	for qemu-devel@nongnu.org; Sat, 27 Mar 2010 08:33:53 -0400
Received: from hall.aurel32.net ([88.191.82.174]:49016)
	by eggs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <aurelien@aurel32.net>) id 1NvVD5-0001YW-Nw
	for qemu-devel@nongnu.org; Sat, 27 Mar 2010 08:33:51 -0400
Date: Sat, 27 Mar 2010 13:33:50 +0100
From: Aurelien Jarno <aurelien@aurel32.net>
Subject: Re: [Qemu-devel] [trivial one-liner] be more specific in -mem-path
	error messages
Message-ID: <20100327123350.GA19617@volta.aurel32.net>
References: <4B9F3AEA.8010408@msgid.tls.msk.ru>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-15
Content-Disposition: inline
In-Reply-To: <4B9F3AEA.8010408@msgid.tls.msk.ru>
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Michael Tokarev <mjt@tls.msk.ru>
Cc: qemu-devel <qemu-devel@nongnu.org>

On Tue, Mar 16, 2010 at 11:01:46AM +0300, Michael Tokarev wrote:
> The error message qemu gives when hugetlbfs is not
> accessible is cryptic at best:
> 
>   mkstemp: Permission denied
> 
> Make it a bit more specific instead:
> 
>  unable to create backing store for hugepages: Permission denied
> 
> Thanks!

It looks good, but needs a Signed-off-by: line.

> /mjt
> 
> diff --git a/exec.c b/exec.c
> index 891e0ee..985bdde 100644
> --- a/exec.c
> +++ b/exec.c
> @@ -2569,5 +2569,5 @@ static void *file_ram_alloc(ram_addr_t memory, const char *path)
>      fd = mkstemp(filename);
>      if (fd < 0) {
> -	perror("mkstemp");
> +	perror("unable to create backing store for hugepages");
>  	free(filename);
>  	return NULL;
> 
> 
> 

-- 
Aurelien Jarno                          GPG: 1024D/F1BCDB73
aurelien@aurel32.net                 http://www.aurel32.net