From: Aurelien Jarno <aurelien@aurel32.net>
To: Ryota Ozaki <ozaki.ryota@gmail.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 1/3] qemu-nbd: Fix return value handling of bdrv_open
Date: Sat, 27 Mar 2010 14:03:34 +0100 [thread overview]
Message-ID: <20100327130334.GL15194@volta.aurel32.net> (raw)
In-Reply-To: <1269066204-4376-1-git-send-email-ozaki.ryota@gmail.com>
On Sat, Mar 20, 2010 at 03:23:22PM +0900, Ryota Ozaki wrote:
> bdrv_open may return -errno so we have to check
> if the return value is '< 0', not '== -1'.
Thanks, applied.
> Signed-off-by: Ryota Ozaki <ozaki.ryota@gmail.com>
> ---
> qemu-nbd.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/qemu-nbd.c b/qemu-nbd.c
> index a393583..b89c361 100644
> --- a/qemu-nbd.c
> +++ b/qemu-nbd.c
> @@ -333,7 +333,7 @@ int main(int argc, char **argv)
> if (bs == NULL)
> return 1;
>
> - if (bdrv_open(bs, argv[optind], flags) == -1)
> + if (bdrv_open(bs, argv[optind], flags) < 0)
> return 1;
>
> fd_size = bs->total_sectors * 512;
> --
> 1.6.5.2
>
>
>
>
--
Aurelien Jarno GPG: 1024D/F1BCDB73
aurelien@aurel32.net http://www.aurel32.net
prev parent reply other threads:[~2010-03-27 13:03 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-20 6:23 [Qemu-devel] [PATCH 1/3] qemu-nbd: Fix return value handling of bdrv_open Ryota Ozaki
2010-03-20 6:23 ` [Qemu-devel] [PATCH 2/3] qemu-nbd: Fix invalid usage of the first argument of errx Ryota Ozaki
2010-03-27 13:03 ` Aurelien Jarno
2010-03-20 6:23 ` [Qemu-devel] [PATCH 3/3] qemu-nbd: Improve error reporting Ryota Ozaki
2010-03-27 13:02 ` Aurelien Jarno
2010-03-28 12:26 ` Ryota Ozaki
2010-03-20 7:01 ` [Qemu-devel] [PATCH 1/3] qemu-nbd: Fix return value handling of bdrv_open Markus Armbruster
2010-03-20 7:05 ` Ryota Ozaki
2010-03-27 13:03 ` Aurelien Jarno [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100327130334.GL15194@volta.aurel32.net \
--to=aurelien@aurel32.net \
--cc=ozaki.ryota@gmail.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).