* [Qemu-devel] [PATCH] qemu-io: fix aio help texts
@ 2010-03-16 18:12 Christoph Hellwig
2010-03-27 12:33 ` Aurelien Jarno
0 siblings, 1 reply; 4+ messages in thread
From: Christoph Hellwig @ 2010-03-16 18:12 UTC (permalink / raw)
To: qemu-devel
Fix a few typos in the helptexts for the various aio commands.
Signed-off-by: Christoph Hellwig <hch@lst.de>
Index: qemu/qemu-io.c
===================================================================
--- qemu.orig/qemu-io.c 2010-03-16 19:07:43.089009269 +0100
+++ qemu/qemu-io.c 2010-03-16 19:08:36.597005148 +0100
@@ -904,8 +904,8 @@ aio_read_help(void)
"\n"
" Reads a segment of the currently open file, optionally dumping it to the\n"
" standard output stream (with -v option) for subsequent inspection.\n"
-" The read is performed asynchronously and should the aio_flush command \n"
-" should be used to ensure all outstanding aio requests have been completed\n"
+" The read is performed asynchronously and the aio_flush command must be\n"
+" to ensure all outstanding aio requests have been completed\n"
" -C, -- report statistics in a machine parsable format\n"
" -P, -- use a pattern to verify read data\n"
" -v, -- dump buffer to standard output\n"
@@ -1003,8 +1003,8 @@ aio_write_help(void)
"\n"
" Writes into a segment of the currently open file, using a buffer\n"
" filled with a set pattern (0xcdcdcdcd).\n"
-" The write is performed asynchronously and should the aio_flush command \n"
-" should be used to ensure all outstanding aio requests have been completed\n"
+" The write is performed asynchronously and the aio_flush command must be\n"
+" used to ensure all outstanding aio requests have been completed\n"
" -P, -- use different pattern to fill file\n"
" -C, -- report statistics in a machine parsable format\n"
" -q, -- quite mode, do not show I/O statistics\n"
@@ -1095,7 +1095,7 @@ aio_flush_f(int argc, char **argv)
static const cmdinfo_t aio_flush_cmd = {
.name = "aio_flush",
.cfunc = aio_flush_f,
- .oneline = "completes all outstanding aio requets"
+ .oneline = "completes all outstanding aio requests"
};
static int
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [Qemu-devel] [PATCH] qemu-io: fix aio help texts
2010-03-16 18:12 [Qemu-devel] [PATCH] qemu-io: fix aio help texts Christoph Hellwig
@ 2010-03-27 12:33 ` Aurelien Jarno
2010-03-28 10:19 ` [Qemu-devel] [PATCH v2] " Christoph Hellwig
0 siblings, 1 reply; 4+ messages in thread
From: Aurelien Jarno @ 2010-03-27 12:33 UTC (permalink / raw)
To: Christoph Hellwig; +Cc: qemu-devel
On Tue, Mar 16, 2010 at 07:12:58PM +0100, Christoph Hellwig wrote:
> Fix a few typos in the helptexts for the various aio commands.
This is clearly an improvement, but it introduces a typo (see below).
> Signed-off-by: Christoph Hellwig <hch@lst.de>
>
> Index: qemu/qemu-io.c
> ===================================================================
> --- qemu.orig/qemu-io.c 2010-03-16 19:07:43.089009269 +0100
> +++ qemu/qemu-io.c 2010-03-16 19:08:36.597005148 +0100
> @@ -904,8 +904,8 @@ aio_read_help(void)
> "\n"
> " Reads a segment of the currently open file, optionally dumping it to the\n"
> " standard output stream (with -v option) for subsequent inspection.\n"
> -" The read is performed asynchronously and should the aio_flush command \n"
> -" should be used to ensure all outstanding aio requests have been completed\n"
> +" The read is performed asynchronously and the aio_flush command must be\n"
"used" is missing here.
> +" to ensure all outstanding aio requests have been completed\n"
> " -C, -- report statistics in a machine parsable format\n"
> " -P, -- use a pattern to verify read data\n"
> " -v, -- dump buffer to standard output\n"
> @@ -1003,8 +1003,8 @@ aio_write_help(void)
> "\n"
> " Writes into a segment of the currently open file, using a buffer\n"
> " filled with a set pattern (0xcdcdcdcd).\n"
> -" The write is performed asynchronously and should the aio_flush command \n"
> -" should be used to ensure all outstanding aio requests have been completed\n"
> +" The write is performed asynchronously and the aio_flush command must be\n"
> +" used to ensure all outstanding aio requests have been completed\n"
> " -P, -- use different pattern to fill file\n"
> " -C, -- report statistics in a machine parsable format\n"
> " -q, -- quite mode, do not show I/O statistics\n"
> @@ -1095,7 +1095,7 @@ aio_flush_f(int argc, char **argv)
> static const cmdinfo_t aio_flush_cmd = {
> .name = "aio_flush",
> .cfunc = aio_flush_f,
> - .oneline = "completes all outstanding aio requets"
> + .oneline = "completes all outstanding aio requests"
> };
>
> static int
>
>
>
--
Aurelien Jarno GPG: 1024D/F1BCDB73
aurelien@aurel32.net http://www.aurel32.net
^ permalink raw reply [flat|nested] 4+ messages in thread* [Qemu-devel] [PATCH v2] qemu-io: fix aio help texts
2010-03-27 12:33 ` Aurelien Jarno
@ 2010-03-28 10:19 ` Christoph Hellwig
2010-03-28 14:58 ` [Qemu-devel] " Aurelien Jarno
0 siblings, 1 reply; 4+ messages in thread
From: Christoph Hellwig @ 2010-03-28 10:19 UTC (permalink / raw)
To: Aurelien Jarno; +Cc: qemu-devel
Fix a few typos in the help texts for the various aio commands.
Signed-off-by: Christoph Hellwig <hch@lst.de>
Index: qemu/qemu-io.c
===================================================================
--- qemu.orig/qemu-io.c 2010-03-16 19:07:43.089009269 +0100
+++ qemu/qemu-io.c 2010-03-16 19:08:36.597005148 +0100
@@ -904,8 +904,8 @@ aio_read_help(void)
"\n"
" Reads a segment of the currently open file, optionally dumping it to the\n"
" standard output stream (with -v option) for subsequent inspection.\n"
-" The read is performed asynchronously and should the aio_flush command \n"
-" should be used to ensure all outstanding aio requests have been completed\n"
+" The read is performed asynchronously and the aio_flush command must be\n"
+" to ensure all outstanding aio requests have been completed\n"
" -C, -- report statistics in a machine parsable format\n"
" -P, -- use a pattern to verify read data\n"
" -v, -- dump buffer to standard output\n"
@@ -1003,8 +1003,8 @@ aio_write_help(void)
"\n"
" Writes into a segment of the currently open file, using a buffer\n"
" filled with a set pattern (0xcdcdcdcd).\n"
-" The write is performed asynchronously and should the aio_flush command \n"
-" should be used to ensure all outstanding aio requests have been completed\n"
+" The write is performed asynchronously and the aio_flush command must be\n"
+" used to ensure all outstanding aio requests have been completed\n"
" -P, -- use different pattern to fill file\n"
" -C, -- report statistics in a machine parsable format\n"
" -q, -- quite mode, do not show I/O statistics\n"
@@ -1095,7 +1095,7 @@ aio_flush_f(int argc, char **argv)
static const cmdinfo_t aio_flush_cmd = {
.name = "aio_flush",
.cfunc = aio_flush_f,
- .oneline = "completes all outstanding aio requets"
+ .oneline = "completes all outstanding aio requests"
};
static int
^ permalink raw reply [flat|nested] 4+ messages in thread* [Qemu-devel] Re: [PATCH v2] qemu-io: fix aio help texts
2010-03-28 10:19 ` [Qemu-devel] [PATCH v2] " Christoph Hellwig
@ 2010-03-28 14:58 ` Aurelien Jarno
0 siblings, 0 replies; 4+ messages in thread
From: Aurelien Jarno @ 2010-03-28 14:58 UTC (permalink / raw)
To: Christoph Hellwig; +Cc: qemu-devel
On Sun, Mar 28, 2010 at 12:19:31PM +0200, Christoph Hellwig wrote:
> Fix a few typos in the help texts for the various aio commands.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
Thanks, applied.
> Index: qemu/qemu-io.c
> ===================================================================
> --- qemu.orig/qemu-io.c 2010-03-16 19:07:43.089009269 +0100
> +++ qemu/qemu-io.c 2010-03-16 19:08:36.597005148 +0100
> @@ -904,8 +904,8 @@ aio_read_help(void)
> "\n"
> " Reads a segment of the currently open file, optionally dumping it to the\n"
> " standard output stream (with -v option) for subsequent inspection.\n"
> -" The read is performed asynchronously and should the aio_flush command \n"
> -" should be used to ensure all outstanding aio requests have been completed\n"
> +" The read is performed asynchronously and the aio_flush command must be\n"
> +" to ensure all outstanding aio requests have been completed\n"
> " -C, -- report statistics in a machine parsable format\n"
> " -P, -- use a pattern to verify read data\n"
> " -v, -- dump buffer to standard output\n"
> @@ -1003,8 +1003,8 @@ aio_write_help(void)
> "\n"
> " Writes into a segment of the currently open file, using a buffer\n"
> " filled with a set pattern (0xcdcdcdcd).\n"
> -" The write is performed asynchronously and should the aio_flush command \n"
> -" should be used to ensure all outstanding aio requests have been completed\n"
> +" The write is performed asynchronously and the aio_flush command must be\n"
> +" used to ensure all outstanding aio requests have been completed\n"
> " -P, -- use different pattern to fill file\n"
> " -C, -- report statistics in a machine parsable format\n"
> " -q, -- quite mode, do not show I/O statistics\n"
> @@ -1095,7 +1095,7 @@ aio_flush_f(int argc, char **argv)
> static const cmdinfo_t aio_flush_cmd = {
> .name = "aio_flush",
> .cfunc = aio_flush_f,
> - .oneline = "completes all outstanding aio requets"
> + .oneline = "completes all outstanding aio requests"
> };
>
> static int
>
--
Aurelien Jarno GPG: 1024D/F1BCDB73
aurelien@aurel32.net http://www.aurel32.net
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2010-03-28 14:58 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-03-16 18:12 [Qemu-devel] [PATCH] qemu-io: fix aio help texts Christoph Hellwig
2010-03-27 12:33 ` Aurelien Jarno
2010-03-28 10:19 ` [Qemu-devel] [PATCH v2] " Christoph Hellwig
2010-03-28 14:58 ` [Qemu-devel] " Aurelien Jarno
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).