From: Luiz Capitulino <lcapitulino@redhat.com>
To: Markus Armbruster <armbru@redhat.com>
Cc: qemu-devel@nongnu.org
Subject: [Qemu-devel] Re: [PATCH v2 0/4] monitor: Convert do_set_link() to QObject, QError
Date: Mon, 29 Mar 2010 16:49:40 -0300 [thread overview]
Message-ID: <20100329164940.359ea994@redhat.com> (raw)
In-Reply-To: <1269590831-26185-1-git-send-email-armbru@redhat.com>
On Fri, 26 Mar 2010 09:07:07 +0100
Markus Armbruster <armbru@redhat.com> wrote:
> PATCH 3/4 changes syntax of set_link's second argument from up|down to
> on|off. I feel that the argument needs to be boolean in QMP, and this
> is the simplest way to get it. Luiz likes this approach. The change
> doesn't affect libvirt, because it doesn't use set_link, yet.
Looks good to me.
prev parent reply other threads:[~2010-03-29 19:49 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-26 8:07 [Qemu-devel] [PATCH v2 0/4] monitor: Convert do_set_link() to QObject, QError Markus Armbruster
2010-03-26 8:07 ` [Qemu-devel] [PATCH v2 1/4] monitor: Rename argument type 'b' to 'f' Markus Armbruster
2010-03-26 8:07 ` [Qemu-devel] [PATCH v2 2/4] monitor: New argument type 'b' Markus Armbruster
2010-03-26 8:07 ` [Qemu-devel] [PATCH v2 3/4] monitor: Use argument type 'b' for set_link Markus Armbruster
2010-03-26 8:07 ` [Qemu-devel] [PATCH v2 4/4] monitor: Convert do_set_link() to QObject, QError Markus Armbruster
2010-03-29 19:49 ` Luiz Capitulino [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100329164940.359ea994@redhat.com \
--to=lcapitulino@redhat.com \
--cc=armbru@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).