From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1NwKyB-0006uN-Sh
	for qemu-devel@nongnu.org; Mon, 29 Mar 2010 15:49:55 -0400
Received: from [140.186.70.92] (port=57313 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1NwKy8-0006rN-G3
	for qemu-devel@nongnu.org; Mon, 29 Mar 2010 15:49:55 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69)
	(envelope-from <lcapitulino@redhat.com>) id 1NwKy6-0004W6-UH
	for qemu-devel@nongnu.org; Mon, 29 Mar 2010 15:49:52 -0400
Received: from mx1.redhat.com ([209.132.183.28]:43150)
	by eggs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <lcapitulino@redhat.com>) id 1NwKy5-0004VB-LV
	for qemu-devel@nongnu.org; Mon, 29 Mar 2010 15:49:50 -0400
Received: from int-mx01.intmail.prod.int.phx2.redhat.com
	(int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11])
	by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o2TJnlU9001309
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)
	for <qemu-devel@nongnu.org>; Mon, 29 Mar 2010 15:49:47 -0400
Date: Mon, 29 Mar 2010 16:49:40 -0300
From: Luiz Capitulino <lcapitulino@redhat.com>
Message-ID: <20100329164940.359ea994@redhat.com>
In-Reply-To: <1269590831-26185-1-git-send-email-armbru@redhat.com>
References: <1269590831-26185-1-git-send-email-armbru@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] Re: [PATCH v2 0/4] monitor: Convert do_set_link() to
 QObject, QError
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Markus Armbruster <armbru@redhat.com>
Cc: qemu-devel@nongnu.org

On Fri, 26 Mar 2010 09:07:07 +0100
Markus Armbruster <armbru@redhat.com> wrote:

> PATCH 3/4 changes syntax of set_link's second argument from up|down to
> on|off.  I feel that the argument needs to be boolean in QMP, and this
> is the simplest way to get it.  Luiz likes this approach.  The change
> doesn't affect libvirt, because it doesn't use set_link, yet.

 Looks good to me.