From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NxJLM-0005pA-2z for qemu-devel@nongnu.org; Thu, 01 Apr 2010 08:17:52 -0400 Received: from [140.186.70.92] (port=58476 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NxJLK-0005ml-L9 for qemu-devel@nongnu.org; Thu, 01 Apr 2010 08:17:51 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1NxJLJ-0004N4-FD for qemu-devel@nongnu.org; Thu, 01 Apr 2010 08:17:50 -0400 Received: from mx20.gnu.org ([199.232.41.8]:39513) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1NxJLJ-0004N0-C1 for qemu-devel@nongnu.org; Thu, 01 Apr 2010 08:17:49 -0400 Received: from mail.codesourcery.com ([38.113.113.100]) by mx20.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1NxJLI-0000i0-Kn for qemu-devel@nongnu.org; Thu, 01 Apr 2010 08:17:48 -0400 From: Paul Brook Subject: Re: [Qemu-devel] [PATCH 2/2] VirtIO RNG Date: Thu, 1 Apr 2010 12:17:45 +0000 References: <4BB2053C.6000701@collabora.co.uk> <4BB206EF.3030100@collabora.co.uk> In-Reply-To: <4BB206EF.3030100@collabora.co.uk> MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Message-Id: <201004011317.45269.paul@codesourcery.com> List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Ian Molton , Gerd Hoffmann > This patch adds support for virtio-rng. Data is read from a chardev > and can be either raw entropy or received via the EGD protocol. I still don't get why you need this at all. It seems like virtio-serial would already provides everything you need. > + qemu_gettimeofday(&now); Using qemu_gettimeofday is almost certainly wrong, and you want to be using virtual time. Plus I'm not convinced this is the right place to enforce rate limiting. Paul