From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NxOw6-0001PT-FH for qemu-devel@nongnu.org; Thu, 01 Apr 2010 14:16:10 -0400 Received: from [140.186.70.92] (port=34862 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NxOw1-0001N9-DB for qemu-devel@nongnu.org; Thu, 01 Apr 2010 14:16:10 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1NxOvx-00072g-Mf for qemu-devel@nongnu.org; Thu, 01 Apr 2010 14:16:05 -0400 Received: from mx1.redhat.com ([209.132.183.28]:53168) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1NxOvx-00071u-Er for qemu-devel@nongnu.org; Thu, 01 Apr 2010 14:16:01 -0400 Date: Thu, 1 Apr 2010 15:15:51 -0300 From: Luiz Capitulino Subject: Re: [Qemu-devel] [PATCH] Add qerror message if the 'change' target filename can't be opened Message-ID: <20100401151551.443ba961@redhat.com> In-Reply-To: <20100325143258.GS27260@us.ibm.com> References: <20100325143258.GS27260@us.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Ryan Harper Cc: qemu-devel@nongnu.org On Thu, 25 Mar 2010 09:32:58 -0500 Ryan Harper wrote: > Currently when using the change command to switch the file in the cd drive > the command doesn't complain if the file doesn't exit or can't be opened > and the drive keeps the existing image. This patch adds a qerror_report > call to print a message out indicating the failure. This error message > can be used to catch failures. Looks good to me, but it doesn't keep the existing image, it will silently eject it instead. > > Current behavior: > > QEMU 0.12.50 monitor - type 'help' for more information > (qemu) info block > ide0-hd0: type=hd removable=0 file=/dev/null ro=0 drv=host_device encrypted=0 > ide1-cd0: type=cdrom removable=1 locked=0 [not inserted] > floppy0: type=floppy removable=1 locked=0 [not inserted] > sd0: type=floppy removable=1 locked=0 [not inserted] > (qemu) change ide1-cd0 /home/rharper/work/isos/Fedora-9-i386-DVD.iso > (qemu) info block > ide0-hd0: type=hd removable=0 file=/dev/null ro=0 drv=host_device encrypted=0 > ide1-cd0: type=cdrom removable=1 locked=0 > file=/home/rharper/work/isos/Fedora-9-i386-DVD.iso ro=0 drv=raw encrypted=0 > floppy0: type=floppy removable=1 locked=0 [not inserted] > sd0: type=floppy removable=1 locked=0 [not inserted] > (qemu) change ide1-cd0 /tmp/non_existent_file.iso > (qemu) info block > ide0-hd0: type=hd removable=0 file=/dev/null ro=0 drv=host_device encrypted=0 > ide1-cd0: type=cdrom removable=1 locked=0 [not inserted] > floppy0: type=floppy removable=1 locked=0 [not inserted] > sd0: type=floppy removable=1 locked=0 [not inserted] > (qemu) > > With patch: > QEMU 0.12.50 monitor - type 'help' for more information > (qemu) change ide1-cd0 /tmp/non_existent_file.iso > Could not open '/tmp/non_existent_file.iso' > (qemu) > > > Signed-off-by: Ryan Harper > --- > monitor.c | 1 + > 1 files changed, 1 insertions(+), 0 deletions(-) > > diff --git a/monitor.c b/monitor.c > index 0448a70..196c7a6 100644 > --- a/monitor.c > +++ b/monitor.c > @@ -1099,6 +1099,7 @@ static int do_change_block(Monitor *mon, const char *device, > return -1; > } > if (bdrv_open2(bs, filename, BDRV_O_RDWR, drv) < 0) { > + qerror_report(QERR_OPEN_FILE_FAILED, filename); > return -1; > } > return monitor_read_bdrv_key_start(mon, bs, NULL, NULL);