From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1NxP31-0003Q6-P8
	for qemu-devel@nongnu.org; Thu, 01 Apr 2010 14:23:19 -0400
Received: from [140.186.70.92] (port=58969 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1NxP2b-0003Lc-Kf
	for qemu-devel@nongnu.org; Thu, 01 Apr 2010 14:23:19 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69)
	(envelope-from <lcapitulino@redhat.com>) id 1NxP2P-0007kS-QC
	for qemu-devel@nongnu.org; Thu, 01 Apr 2010 14:22:43 -0400
Received: from mx1.redhat.com ([209.132.183.28]:34190)
	by eggs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <lcapitulino@redhat.com>) id 1NxP2P-0007kJ-Gw
	for qemu-devel@nongnu.org; Thu, 01 Apr 2010 14:22:41 -0400
Date: Thu, 1 Apr 2010 15:22:33 -0300
From: Luiz Capitulino <lcapitulino@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] Add qerror message if the 'change' target
	filename can't be opened
Message-ID: <20100401152233.71e778ed@redhat.com>
In-Reply-To: <20100401151551.443ba961@redhat.com>
References: <20100325143258.GS27260@us.ibm.com>
	<20100401151551.443ba961@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Ryan Harper <ryanh@us.ibm.com>
Cc: kwolf@redhat.com, qemu-devel@nongnu.org

On Thu, 1 Apr 2010 15:15:51 -0300
Luiz Capitulino <lcapitulino@redhat.com> wrote:

> On Thu, 25 Mar 2010 09:32:58 -0500
> Ryan Harper <ryanh@us.ibm.com> wrote:
> 
> > Currently when using the change command to switch the file in the cd drive
> > the command doesn't complain if the file doesn't exit or can't be opened
> > and the drive keeps the existing image.  This patch adds a qerror_report
> > call to print a message out indicating the failure.  This error message
> > can be used to catch failures.
> 
>  Looks good to me, but it doesn't keep the existing image, it will silently
> eject it instead.

 And, thinking more about it this seems the wrong behavior to me, if it
fails to open the file, it should not touch the current one.

 Am I right, Kevin?