From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NxP3x-0003mK-EJ for qemu-devel@nongnu.org; Thu, 01 Apr 2010 14:24:17 -0400 Received: from [140.186.70.92] (port=59194 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NxP3v-0003m6-6n for qemu-devel@nongnu.org; Thu, 01 Apr 2010 14:24:16 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1NxP3r-0007vt-2b for qemu-devel@nongnu.org; Thu, 01 Apr 2010 14:24:12 -0400 Received: from e38.co.us.ibm.com ([32.97.110.159]:57847) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1NxP3q-0007um-TV for qemu-devel@nongnu.org; Thu, 01 Apr 2010 14:24:11 -0400 Received: from d03relay01.boulder.ibm.com (d03relay01.boulder.ibm.com [9.17.195.226]) by e38.co.us.ibm.com (8.14.3/8.13.1) with ESMTP id o31II7F2021910 for ; Thu, 1 Apr 2010 12:18:07 -0600 Received: from d03av01.boulder.ibm.com (d03av01.boulder.ibm.com [9.17.195.167]) by d03relay01.boulder.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id o31INlhJ162576 for ; Thu, 1 Apr 2010 12:23:48 -0600 Received: from d03av01.boulder.ibm.com (loopback [127.0.0.1]) by d03av01.boulder.ibm.com (8.14.3/8.13.1/NCO v10.0 AVout) with ESMTP id o31INlMc011363 for ; Thu, 1 Apr 2010 12:23:47 -0600 Date: Thu, 1 Apr 2010 13:23:44 -0500 From: Ryan Harper Subject: Re: [Qemu-devel] [PATCH] Add qerror message if the 'change' target filename can't be opened Message-ID: <20100401182344.GV24351@us.ibm.com> References: <20100325143258.GS27260@us.ibm.com> <20100401151551.443ba961@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20100401151551.443ba961@redhat.com> List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Luiz Capitulino Cc: Ryan Harper , qemu-devel@nongnu.org * Luiz Capitulino [2010-04-01 13:17]: > On Thu, 25 Mar 2010 09:32:58 -0500 > Ryan Harper wrote: > > > Currently when using the change command to switch the file in the cd drive > > the command doesn't complain if the file doesn't exit or can't be opened > > and the drive keeps the existing image. This patch adds a qerror_report > > call to print a message out indicating the failure. This error message > > can be used to catch failures. > > Looks good to me, but it doesn't keep the existing image, it will silently > eject it instead. That's true, but that happens whether or not we indicate the change failed. I think fixing that is a good idea, but it shouldn't part of this patch (just indicating the failure). -- Ryan Harper Software Engineer; Linux Technology Center IBM Corp., Austin, Tx ryanh@us.ibm.com