* [Qemu-devel] [PATCHv2] usb-bus: fix no params
@ 2010-03-30 1:33 TeLeMan
2010-04-02 10:16 ` Aurelien Jarno
0 siblings, 1 reply; 2+ messages in thread
From: TeLeMan @ 2010-03-30 1:33 UTC (permalink / raw)
To: qemu-devel
After commit 702f3e0fb52c124c07f215426eeadb70a716643f, the params is
nerver NULL. It should check *params instead of params to determine
whether the params is empty.
Signed-off-by: TeLeMan <geleman@gmail.com>
---
hw/usb-bus.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/hw/usb-bus.c b/hw/usb-bus.c
index ce8a694..ee0e9e3 100644
--- a/hw/usb-bus.c
+++ b/hw/usb-bus.c
@@ -299,7 +299,7 @@ USBDevice *usbdevice_create(const char *cmdline)
}
if (!usb->usbdevice_init) {
- if (params) {
+ if (*params) {
error_report("usbdevice %s accepts no params", driver);
return NULL;
}
--
1.6.5.1.1367.gcd48
--
SUN OF A BEACH
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [Qemu-devel] [PATCHv2] usb-bus: fix no params
2010-03-30 1:33 [Qemu-devel] [PATCHv2] usb-bus: fix no params TeLeMan
@ 2010-04-02 10:16 ` Aurelien Jarno
0 siblings, 0 replies; 2+ messages in thread
From: Aurelien Jarno @ 2010-04-02 10:16 UTC (permalink / raw)
To: TeLeMan; +Cc: qemu-devel
On Tue, Mar 30, 2010 at 09:33:24AM +0800, TeLeMan wrote:
> After commit 702f3e0fb52c124c07f215426eeadb70a716643f, the params is
> nerver NULL. It should check *params instead of params to determine
> whether the params is empty.
>
> Signed-off-by: TeLeMan <geleman@gmail.com>
Thanks, applied.
> ---
> hw/usb-bus.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/hw/usb-bus.c b/hw/usb-bus.c
> index ce8a694..ee0e9e3 100644
> --- a/hw/usb-bus.c
> +++ b/hw/usb-bus.c
> @@ -299,7 +299,7 @@ USBDevice *usbdevice_create(const char *cmdline)
> }
>
> if (!usb->usbdevice_init) {
> - if (params) {
> + if (*params) {
> error_report("usbdevice %s accepts no params", driver);
> return NULL;
> }
> --
> 1.6.5.1.1367.gcd48
>
> --
> SUN OF A BEACH
>
>
>
--
Aurelien Jarno GPG: 1024D/F1BCDB73
aurelien@aurel32.net http://www.aurel32.net
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-04-02 10:17 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-03-30 1:33 [Qemu-devel] [PATCHv2] usb-bus: fix no params TeLeMan
2010-04-02 10:16 ` Aurelien Jarno
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).