* [Qemu-devel] [BREAKAGE] commit 9bc6304c156dcc01c619672ca33d7152bb18bcb9 breaks build
@ 2010-04-02 9:38 Roy Tam
2010-04-02 12:15 ` Anthony Liguori
0 siblings, 1 reply; 9+ messages in thread
From: Roy Tam @ 2010-04-02 9:38 UTC (permalink / raw)
To: qemu-devel
Config:
Install prefix c:/Program Files/Qemu
BIOS directory c:/Program Files/Qemu
binary directory c:/Program Files/Qemu
Source path /usr/home/User/qemu
C compiler gcc
Host C compiler gcc
CFLAGS -O2 -g
QEMU_CFLAGS -m32 -D__USE_MINGW_ANSI_STDIO=1
-DWIN32_LEAN_AND_MEAN -DWINVER=0x501 -Wold-style-definition -I.
-I$(SRC_PATH) -D_FORTIFY_SOURCE=2 -D_GNU_SOURCE -D_FILE_OFFSET_BITS=64
-D_LARGEFILE_SOURCE -Wstrict-prototypes -Wredundant-decls -Wall
-Wundef -Wendif-labels -Wwrite-strings -Wmissing-prototypes
-fno-strict-aliasing
LDFLAGS -Wl,--warn-common -m32 -g
make make
install install
host CPU i386
host big endian no
target list i386-softmmu x86_64-softmmu mips64el-softmmu
tcg debug enabled no
Mon debug enabled no
gprof enabled no
sparse enabled no
strip binaries yes
profiler no
static build no
-Werror enabled no
SDL support yes
curses support no
curl support no
check support no
mingw32 support yes
Audio drivers sdl
Extra audio cards ac97 sb16 adlib
Block whitelist
Mixer emulation no
VNC TLS support no
VNC SASL support no
xen support no
brlapi support no
bluez support no
Documentation yes
NPTL support no
GUEST_BASE yes
PIE user targets no
vde support no
IO thread no
Linux AIO support no
Install blobs yes
KVM support no
fdt support no
preadv support no
fdatasync no
uuid support no
vhost-net support no
Error log:
LINK i386-softmmu/qemu.exe
virtio-net.o: In function `virtio_net_reset':
C:/msys/home/User/qemu/hw/virtio-net.c:122: undefined reference to
`tap_get_vhost_net'
virtio-net.o: In function `virtio_net_get_features':
C:/msys/home/User/qemu/hw/virtio-net.c:187: undefined reference to
`tap_get_vhost_net'
C:/msys/home/User/qemu/hw/virtio-net.c:190: undefined reference to
`tap_get_vhost_net'
virtio-net.o: In function `virtio_net_save':
C:/msys/home/User/qemu/hw/virtio-net.c:719: undefined reference to
`tap_get_vhost_net'
virtio-net.o: In function `virtio_net_set_status':
C:/msys/home/User/qemu/hw/virtio-net.c:863: undefined reference to
`tap_get_vhost_net'
virtio-net.o:C:/msys/home/User/qemu/hw/virtio-net.c:870: more
undefined references to `tap_get_vhost_net' follow
collect2: ld returned 1 exit status
make[1]: *** [qemu.exe] Error 1
make: *** [subdir-i386-softmmu] Error 2
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [Qemu-devel] [BREAKAGE] commit 9bc6304c156dcc01c619672ca33d7152bb18bcb9 breaks build
2010-04-02 9:38 [Qemu-devel] [BREAKAGE] commit 9bc6304c156dcc01c619672ca33d7152bb18bcb9 breaks build Roy Tam
@ 2010-04-02 12:15 ` Anthony Liguori
2010-04-02 12:16 ` Roy Tam
0 siblings, 1 reply; 9+ messages in thread
From: Anthony Liguori @ 2010-04-02 12:15 UTC (permalink / raw)
To: Roy Tam; +Cc: qemu-devel
[-- Attachment #1: Type: text/plain, Size: 2515 bytes --]
Try doing a clean build
On Apr 2, 2010 4:43 AM, "Roy Tam" <roytam@gmail.com> wrote:
Config:
Install prefix c:/Program Files/Qemu
BIOS directory c:/Program Files/Qemu
binary directory c:/Program Files/Qemu
Source path /usr/home/User/qemu
C compiler gcc
Host C compiler gcc
CFLAGS -O2 -g
QEMU_CFLAGS -m32 -D__USE_MINGW_ANSI_STDIO=1
-DWIN32_LEAN_AND_MEAN -DWINVER=0x501 -Wold-style-definition -I.
-I$(SRC_PATH) -D_FORTIFY_SOURCE=2 -D_GNU_SOURCE -D_FILE_OFFSET_BITS=64
-D_LARGEFILE_SOURCE -Wstrict-prototypes -Wredundant-decls -Wall
-Wundef -Wendif-labels -Wwrite-strings -Wmissing-prototypes
-fno-strict-aliasing
LDFLAGS -Wl,--warn-common -m32 -g
make make
install install
host CPU i386
host big endian no
target list i386-softmmu x86_64-softmmu mips64el-softmmu
tcg debug enabled no
Mon debug enabled no
gprof enabled no
sparse enabled no
strip binaries yes
profiler no
static build no
-Werror enabled no
SDL support yes
curses support no
curl support no
check support no
mingw32 support yes
Audio drivers sdl
Extra audio cards ac97 sb16 adlib
Block whitelist
Mixer emulation no
VNC TLS support no
VNC SASL support no
xen support no
brlapi support no
bluez support no
Documentation yes
NPTL support no
GUEST_BASE yes
PIE user targets no
vde support no
IO thread no
Linux AIO support no
Install blobs yes
KVM support no
fdt support no
preadv support no
fdatasync no
uuid support no
vhost-net support no
Error log:
LINK i386-softmmu/qemu.exe
virtio-net.o: In function `virtio_net_reset':
C:/msys/home/User/qemu/hw/virtio-net.c:122: undefined reference to
`tap_get_vhost_net'
virtio-net.o: In function `virtio_net_get_features':
C:/msys/home/User/qemu/hw/virtio-net.c:187: undefined reference to
`tap_get_vhost_net'
C:/msys/home/User/qemu/hw/virtio-net.c:190: undefined reference to
`tap_get_vhost_net'
virtio-net.o: In function `virtio_net_save':
C:/msys/home/User/qemu/hw/virtio-net.c:719: undefined reference to
`tap_get_vhost_net'
virtio-net.o: In function `virtio_net_set_status':
C:/msys/home/User/qemu/hw/virtio-net.c:863: undefined reference to
`tap_get_vhost_net'
virtio-net.o:C:/msys/home/User/qemu/hw/virtio-net.c:870: more
undefined references to `tap_get_vhost_net' follow
collect2: ld returned 1 exit status
make[1]: *** [qemu.exe] Error 1
make: *** [subdir-i386-softmmu] Error 2
[-- Attachment #2: Type: text/html, Size: 3076 bytes --]
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [Qemu-devel] [BREAKAGE] commit 9bc6304c156dcc01c619672ca33d7152bb18bcb9 breaks build
2010-04-02 12:15 ` Anthony Liguori
@ 2010-04-02 12:16 ` Roy Tam
2010-04-02 14:09 ` Blue Swirl
0 siblings, 1 reply; 9+ messages in thread
From: Roy Tam @ 2010-04-02 12:16 UTC (permalink / raw)
To: Anthony Liguori; +Cc: qemu-devel
2010/4/2 Anthony Liguori <anthony@codemonkey.ws>:
> Try doing a clean build
This is a fresh checkout.
>
> On Apr 2, 2010 4:43 AM, "Roy Tam" <roytam@gmail.com> wrote:
>
> Config:
>
> Install prefix c:/Program Files/Qemu
> BIOS directory c:/Program Files/Qemu
> binary directory c:/Program Files/Qemu
> Source path /usr/home/User/qemu
> C compiler gcc
> Host C compiler gcc
> CFLAGS -O2 -g
> QEMU_CFLAGS -m32 -D__USE_MINGW_ANSI_STDIO=1
> -DWIN32_LEAN_AND_MEAN -DWINVER=0x501 -Wold-style-definition -I.
> -I$(SRC_PATH) -D_FORTIFY_SOURCE=2 -D_GNU_SOURCE -D_FILE_OFFSET_BITS=64
> -D_LARGEFILE_SOURCE -Wstrict-prototypes -Wredundant-decls -Wall
> -Wundef -Wendif-labels -Wwrite-strings -Wmissing-prototypes
> -fno-strict-aliasing
> LDFLAGS -Wl,--warn-common -m32 -g
> make make
> install install
> host CPU i386
> host big endian no
> target list i386-softmmu x86_64-softmmu mips64el-softmmu
> tcg debug enabled no
> Mon debug enabled no
> gprof enabled no
> sparse enabled no
> strip binaries yes
> profiler no
> static build no
> -Werror enabled no
> SDL support yes
> curses support no
> curl support no
> check support no
> mingw32 support yes
> Audio drivers sdl
> Extra audio cards ac97 sb16 adlib
> Block whitelist
> Mixer emulation no
> VNC TLS support no
> VNC SASL support no
> xen support no
> brlapi support no
> bluez support no
> Documentation yes
> NPTL support no
> GUEST_BASE yes
> PIE user targets no
> vde support no
> IO thread no
> Linux AIO support no
> Install blobs yes
> KVM support no
> fdt support no
> preadv support no
> fdatasync no
> uuid support no
> vhost-net support no
>
> Error log:
> LINK i386-softmmu/qemu.exe
> virtio-net.o: In function `virtio_net_reset':
> C:/msys/home/User/qemu/hw/virtio-net.c:122: undefined reference to
> `tap_get_vhost_net'
> virtio-net.o: In function `virtio_net_get_features':
> C:/msys/home/User/qemu/hw/virtio-net.c:187: undefined reference to
> `tap_get_vhost_net'
> C:/msys/home/User/qemu/hw/virtio-net.c:190: undefined reference to
> `tap_get_vhost_net'
> virtio-net.o: In function `virtio_net_save':
> C:/msys/home/User/qemu/hw/virtio-net.c:719: undefined reference to
> `tap_get_vhost_net'
> virtio-net.o: In function `virtio_net_set_status':
> C:/msys/home/User/qemu/hw/virtio-net.c:863: undefined reference to
> `tap_get_vhost_net'
> virtio-net.o:C:/msys/home/User/qemu/hw/virtio-net.c:870: more
> undefined references to `tap_get_vhost_net' follow
> collect2: ld returned 1 exit status
> make[1]: *** [qemu.exe] Error 1
> make: *** [subdir-i386-softmmu] Error 2
>
>
>
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [Qemu-devel] [BREAKAGE] commit 9bc6304c156dcc01c619672ca33d7152bb18bcb9 breaks build
2010-04-02 12:16 ` Roy Tam
@ 2010-04-02 14:09 ` Blue Swirl
2010-04-02 14:30 ` Stefan Weil
0 siblings, 1 reply; 9+ messages in thread
From: Blue Swirl @ 2010-04-02 14:09 UTC (permalink / raw)
To: Roy Tam; +Cc: qemu-devel, Michael S. Tsirkin
On 4/2/10, Roy Tam <roytam@gmail.com> wrote:
> 2010/4/2 Anthony Liguori <anthony@codemonkey.ws>:
>
> > Try doing a clean build
>
>
> This is a fresh checkout.
I can confirm this with mingw32:
LINK sparc64-softmmu/qemu-system-sparc64.exe
virtio-net.o: In function `virtio_net_exit':
/src/qemu/hw/virtio-net.c:943: undefined reference to `_tap_get_vhost_net'
virtio-net.o: In function `virtio_net_save':
/src/qemu/hw/virtio-net.c:719: undefined reference to `_tap_get_vhost_net'
virtio-net.o: In function `virtio_net_reset':
/src/qemu/hw/virtio-net.c:122: undefined reference to `_tap_get_vhost_net'
virtio-net.o: In function `virtio_net_set_status':
/src/qemu/hw/virtio-net.c:863: undefined reference to `_tap_get_vhost_net'
/src/qemu/hw/virtio-net.c:870: undefined reference to `_tap_get_vhost_net'
virtio-net.o:/src/qemu/hw/virtio-net.c:878: more undefined references
to `_tap_get_vhost_net' follow
collect2: ld returned 1 exit status
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [Qemu-devel] [BREAKAGE] commit 9bc6304c156dcc01c619672ca33d7152bb18bcb9 breaks build
2010-04-02 14:09 ` Blue Swirl
@ 2010-04-02 14:30 ` Stefan Weil
2010-04-02 15:27 ` Anthony Liguori
0 siblings, 1 reply; 9+ messages in thread
From: Stefan Weil @ 2010-04-02 14:30 UTC (permalink / raw)
To: Blue Swirl; +Cc: Michael S. Tsirkin, qemu-devel, Roy Tam
Blue Swirl schrieb:
> On 4/2/10, Roy Tam <roytam@gmail.com> wrote:
>> 2010/4/2 Anthony Liguori <anthony@codemonkey.ws>:
>>
>>> Try doing a clean build
>>
>> This is a fresh checkout.
>
> I can confirm this with mingw32:
> LINK sparc64-softmmu/qemu-system-sparc64.exe
> virtio-net.o: In function `virtio_net_exit':
> /src/qemu/hw/virtio-net.c:943: undefined reference to `_tap_get_vhost_net'
> virtio-net.o: In function `virtio_net_save':
> /src/qemu/hw/virtio-net.c:719: undefined reference to `_tap_get_vhost_net'
> virtio-net.o: In function `virtio_net_reset':
> /src/qemu/hw/virtio-net.c:122: undefined reference to `_tap_get_vhost_net'
> virtio-net.o: In function `virtio_net_set_status':
> /src/qemu/hw/virtio-net.c:863: undefined reference to `_tap_get_vhost_net'
> /src/qemu/hw/virtio-net.c:870: undefined reference to `_tap_get_vhost_net'
> virtio-net.o:/src/qemu/hw/virtio-net.c:878: more undefined references
> to `_tap_get_vhost_net' follow
> collect2: ld returned 1 exit status
A cross build (mingw32 on debian) also results in this linker error.
The reason is quite simple: tap.o (which provides tap_get_vhost_net)
is only build for posix systems, but not for windows:
Makefile.objs:net-nested-$(CONFIG_POSIX) += tap.o
Changing this does not help because tap.c does not
compile for win32 without errors. Either these errors
have to be fixed, or don't call tap_get_vhost_net when
compiling for win32.
Stefan
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [Qemu-devel] [BREAKAGE] commit 9bc6304c156dcc01c619672ca33d7152bb18bcb9 breaks build
2010-04-02 14:30 ` Stefan Weil
@ 2010-04-02 15:27 ` Anthony Liguori
2010-04-02 15:41 ` Anthony Liguori
0 siblings, 1 reply; 9+ messages in thread
From: Anthony Liguori @ 2010-04-02 15:27 UTC (permalink / raw)
To: Stefan Weil; +Cc: Blue Swirl, Roy Tam, qemu-devel, Michael S. Tsirkin
On 04/02/2010 09:30 AM, Stefan Weil wrote:
> Blue Swirl schrieb:
>
>> On 4/2/10, Roy Tam<roytam@gmail.com> wrote:
>>
>>> 2010/4/2 Anthony Liguori<anthony@codemonkey.ws>:
>>>
>>>
>>>> Try doing a clean build
>>>>
>>> This is a fresh checkout.
>>>
>> I can confirm this with mingw32:
>> LINK sparc64-softmmu/qemu-system-sparc64.exe
>> virtio-net.o: In function `virtio_net_exit':
>> /src/qemu/hw/virtio-net.c:943: undefined reference to `_tap_get_vhost_net'
>> virtio-net.o: In function `virtio_net_save':
>> /src/qemu/hw/virtio-net.c:719: undefined reference to `_tap_get_vhost_net'
>> virtio-net.o: In function `virtio_net_reset':
>> /src/qemu/hw/virtio-net.c:122: undefined reference to `_tap_get_vhost_net'
>> virtio-net.o: In function `virtio_net_set_status':
>> /src/qemu/hw/virtio-net.c:863: undefined reference to `_tap_get_vhost_net'
>> /src/qemu/hw/virtio-net.c:870: undefined reference to `_tap_get_vhost_net'
>> virtio-net.o:/src/qemu/hw/virtio-net.c:878: more undefined references
>> to `_tap_get_vhost_net' follow
>> collect2: ld returned 1 exit status
>>
> A cross build (mingw32 on debian) also results in this linker error.
> The reason is quite simple: tap.o (which provides tap_get_vhost_net)
> is only build for posix systems, but not for windows:
>
> Makefile.objs:net-nested-$(CONFIG_POSIX) += tap.o
>
> Changing this does not help because tap.c does not
> compile for win32 without errors. Either these errors
> have to be fixed, or don't call tap_get_vhost_net when
> compiling for win32.
>
This tap files are a bit odd. We don't compile tap.o for mingw32 but we
do compile tap-win32.o so what we need to do is define tap_get_vhost_net
in tap-win32.c. Testing a patch right now.
Regards,
Anthony Liguori
> Stefan
>
>
>
>
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [Qemu-devel] [BREAKAGE] commit 9bc6304c156dcc01c619672ca33d7152bb18bcb9 breaks build
2010-04-02 15:27 ` Anthony Liguori
@ 2010-04-02 15:41 ` Anthony Liguori
2010-04-04 10:31 ` Michael S. Tsirkin
2010-04-04 10:35 ` Roy Tam
0 siblings, 2 replies; 9+ messages in thread
From: Anthony Liguori @ 2010-04-02 15:41 UTC (permalink / raw)
To: Stefan Weil; +Cc: Blue Swirl, Roy Tam, qemu-devel, Michael S. Tsirkin
On 04/02/2010 10:27 AM, Anthony Liguori wrote:
>
> This tap files are a bit odd. We don't compile tap.o for mingw32 but
> we do compile tap-win32.o so what we need to do is define
> tap_get_vhost_net in tap-win32.c. Testing a patch right now.
I pushed a fix that does exactly this.
Regards,
Anthony Liguori
> Regards,
>
> Anthony Liguori
>
>> Stefan
>>
>>
>>
>
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [Qemu-devel] [BREAKAGE] commit 9bc6304c156dcc01c619672ca33d7152bb18bcb9 breaks build
2010-04-02 15:41 ` Anthony Liguori
@ 2010-04-04 10:31 ` Michael S. Tsirkin
2010-04-04 10:35 ` Roy Tam
1 sibling, 0 replies; 9+ messages in thread
From: Michael S. Tsirkin @ 2010-04-04 10:31 UTC (permalink / raw)
To: Anthony Liguori; +Cc: Blue Swirl, qemu-devel, Roy Tam
On Fri, Apr 02, 2010 at 10:41:03AM -0500, Anthony Liguori wrote:
> On 04/02/2010 10:27 AM, Anthony Liguori wrote:
>>
>> This tap files are a bit odd. We don't compile tap.o for mingw32 but
>> we do compile tap-win32.o so what we need to do is define
>> tap_get_vhost_net in tap-win32.c. Testing a patch right now.
>
> I pushed a fix that does exactly this.
>
> Regards,
>
> Anthony Liguori
Thanks for fixing this!
>> Regards,
>>
>> Anthony Liguori
>>
>>> Stefan
>>>
>>>
>>>
>>
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [Qemu-devel] [BREAKAGE] commit 9bc6304c156dcc01c619672ca33d7152bb18bcb9 breaks build
2010-04-02 15:41 ` Anthony Liguori
2010-04-04 10:31 ` Michael S. Tsirkin
@ 2010-04-04 10:35 ` Roy Tam
1 sibling, 0 replies; 9+ messages in thread
From: Roy Tam @ 2010-04-04 10:35 UTC (permalink / raw)
To: Anthony Liguori; +Cc: Blue Swirl, qemu-devel, Michael S. Tsirkin
2010/4/2 Anthony Liguori <anthony@codemonkey.ws>:
> On 04/02/2010 10:27 AM, Anthony Liguori wrote:
>>
>> This tap files are a bit odd. We don't compile tap.o for mingw32 but we
>> do compile tap-win32.o so what we need to do is define tap_get_vhost_net in
>> tap-win32.c. Testing a patch right now.
>
> I pushed a fix that does exactly this.
>
Confirmed. Thanks.
> Regards,
>
> Anthony Liguori
>
>> Regards,
>>
>> Anthony Liguori
>>
>>> Stefan
>>>
>>>
>>>
>>
>
>
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2010-04-04 10:36 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-04-02 9:38 [Qemu-devel] [BREAKAGE] commit 9bc6304c156dcc01c619672ca33d7152bb18bcb9 breaks build Roy Tam
2010-04-02 12:15 ` Anthony Liguori
2010-04-02 12:16 ` Roy Tam
2010-04-02 14:09 ` Blue Swirl
2010-04-02 14:30 ` Stefan Weil
2010-04-02 15:27 ` Anthony Liguori
2010-04-02 15:41 ` Anthony Liguori
2010-04-04 10:31 ` Michael S. Tsirkin
2010-04-04 10:35 ` Roy Tam
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).