From: Paul Brook <paul@codesourcery.com>
To: Blue Swirl <blauwirbel@gmail.com>, qemu-devel@nongnu.org
Subject: [Qemu-devel] Revert bogus usb-ohci change
Date: Sun, 4 Apr 2010 21:30:23 +0100 [thread overview]
Message-ID: <201004042130.23957.paul@codesourcery.com> (raw)
Commit f1698408 "Compile usb-ohci only once" introduces a "be" property to the
pci-ohci device. The PCI bus is always little-endian, so this is completely
bogus. A hypothetical big-endian device would actually introduce another
byteswap.
As discussed previously, if you really want to avoid compiling the device
multiple times then this needs to be fixed elsewhere. Adding user visible
properties to devices is definitely not the right solution.
I have reverted this change. If there are other devices that have been hacked
in the same way then please revert those too.
Paul
next reply other threads:[~2010-04-04 20:30 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-04 20:30 Paul Brook [this message]
2010-04-04 21:02 ` [Qemu-devel] Re: Revert bogus usb-ohci change Blue Swirl
2010-04-04 21:28 ` Paul Brook
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201004042130.23957.paul@codesourcery.com \
--to=paul@codesourcery.com \
--cc=blauwirbel@gmail.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).