From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NyWSn-0000w0-55 for qemu-devel@nongnu.org; Sun, 04 Apr 2010 16:30:33 -0400 Received: from [140.186.70.92] (port=55040 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NyWSl-0000uU-Uv for qemu-devel@nongnu.org; Sun, 04 Apr 2010 16:30:32 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1NyWSk-00081x-38 for qemu-devel@nongnu.org; Sun, 04 Apr 2010 16:30:31 -0400 Received: from mx20.gnu.org ([199.232.41.8]:64556) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1NyWSk-00081t-0D for qemu-devel@nongnu.org; Sun, 04 Apr 2010 16:30:30 -0400 Received: from mail.codesourcery.com ([38.113.113.100]) by mx20.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1NyWSj-0008VL-Hh for qemu-devel@nongnu.org; Sun, 04 Apr 2010 16:30:29 -0400 From: Paul Brook Date: Sun, 4 Apr 2010 21:30:23 +0100 MIME-Version: 1.0 Content-Type: Text/Plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Message-Id: <201004042130.23957.paul@codesourcery.com> Subject: [Qemu-devel] Revert bogus usb-ohci change List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Blue Swirl , qemu-devel@nongnu.org Commit f1698408 "Compile usb-ohci only once" introduces a "be" property to the pci-ohci device. The PCI bus is always little-endian, so this is completely bogus. A hypothetical big-endian device would actually introduce another byteswap. As discussed previously, if you really want to avoid compiling the device multiple times then this needs to be fixed elsewhere. Adding user visible properties to devices is definitely not the right solution. I have reverted this change. If there are other devices that have been hacked in the same way then please revert those too. Paul