From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Nyi6M-0008Iw-Is for qemu-devel@nongnu.org; Mon, 05 Apr 2010 04:56:10 -0400 Received: from [140.186.70.92] (port=53003 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Nyi6K-0008Io-KN for qemu-devel@nongnu.org; Mon, 05 Apr 2010 04:56:09 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1Nyi6J-0001nq-4J for qemu-devel@nongnu.org; Mon, 05 Apr 2010 04:56:08 -0400 Received: from verein.lst.de ([213.95.11.210]:47091) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Nyi6I-0001nL-PC for qemu-devel@nongnu.org; Mon, 05 Apr 2010 04:56:07 -0400 Date: Mon, 5 Apr 2010 10:55:58 +0200 From: Christoph Hellwig Subject: Re: [Qemu-devel] [PATCH] Replace calls of old bdrv_open Message-ID: <20100405085558.GA12779@lst.de> References: <1270039576-11968-1-git-send-email-kwolf@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1270039576-11968-1-git-send-email-kwolf@redhat.com> List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf Cc: qemu-devel@nongnu.org On Wed, Mar 31, 2010 at 02:46:16PM +0200, Kevin Wolf wrote: > What is known today as bdrv_open2 becomes the new bdrv_open. All remaining > callers of the old function are converted to the new one. In some places they > even know the right format, so they should have used bdrv_open2 from the > beginning. Looks good. I had a patch doing the same but wasn't sure if it's worth bothering.