From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1NzJdD-000768-UV
	for qemu-devel@nongnu.org; Tue, 06 Apr 2010 21:00:35 -0400
Received: from [140.186.70.92] (port=48889 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1NzJdC-00075H-M4
	for qemu-devel@nongnu.org; Tue, 06 Apr 2010 21:00:35 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69)
	(envelope-from <paul@codesourcery.com>) id 1NzJdB-0002eo-3g
	for qemu-devel@nongnu.org; Tue, 06 Apr 2010 21:00:34 -0400
Received: from mx20.gnu.org ([199.232.41.8]:16568)
	by eggs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <paul@codesourcery.com>) id 1NzJdB-0002ek-27
	for qemu-devel@nongnu.org; Tue, 06 Apr 2010 21:00:33 -0400
Received: from mail.codesourcery.com ([38.113.113.100])
	by mx20.gnu.org with esmtp (Exim 4.60)
	(envelope-from <paul@codesourcery.com>) id 1NzJdA-0006f2-Ag
	for qemu-devel@nongnu.org; Tue, 06 Apr 2010 21:00:32 -0400
From: Paul Brook <paul@codesourcery.com>
Subject: Re: [Qemu-devel] [PATCH 6/9] eepro100: Support compilation without
	EEPROM
Date: Wed, 7 Apr 2010 02:00:22 +0100
References: <1270554249-24861-1-git-send-email-weil@mail.berlios.de>
	<1270554249-24861-7-git-send-email-weil@mail.berlios.de>
In-Reply-To: <1270554249-24861-7-git-send-email-weil@mail.berlios.de>
MIME-Version: 1.0
Content-Type: Text/Plain;
  charset="iso-8859-15"
Content-Transfer-Encoding: 7bit
Message-Id: <201004070200.23054.paul@codesourcery.com>
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org
Cc: "Michael S. Tsirkin" <mst@redhat.com>

> To emulate hardware without an EEPROM,
> EEPROM_SIZE may be set to 0.

If might, but it isn't.

This patch introduces a condition that will never be false. Please don't do 
that.  I consider code that is never used to be actively harmful. Any feature 
that requires the user hack the source may as well not exist.  The only 
possible exception is debug output intended solely for qemu developers.

If there's something worth noting for future reference then add a proper 
comment, if necessary marked as TODO/FIXME.

Paul