qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Grant Likely <grant.likely@secretlab.ca>
To: qemu-devel@nongnu.org, devicetree-discuss@lists.ozlabs.org,
	jeremy.kerr@canonical.com
Subject: [Qemu-devel] [RFC PATCH 1/7] devicetree: Add 8k instead of double dtb size when reserving extra memory
Date: Tue, 06 Apr 2010 22:10:02 -0600	[thread overview]
Message-ID: <20100407041002.20274.51604.stgit@angua> (raw)
In-Reply-To: <20100407040129.20274.44284.stgit@angua>

If a small 'seed' dtb file is loaded into qemu and then heavily modified
(say for runtime population of all the device nodes), then 2x the dtb
size turns out not to be very much.

This patch changes the device tree loading code to add a fixed 8k of
additional space to the dtb buffer.

Signed-off-by: Grant Likely <grant.likely@secretlab.ca>
---

 device_tree.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/device_tree.c b/device_tree.c
index 426a631..bad4810 100644
--- a/device_tree.c
+++ b/device_tree.c
@@ -41,8 +41,8 @@ void *load_device_tree(const char *filename_path, int *sizep)
         goto fail;
     }
 
-    /* Expand to 2x size to give enough room for manipulation.  */
-    dt_size *= 2;
+    /* Expand size to give enough room for manipulation.  */
+    dt_size += 8 * 1024;
     /* First allocate space in qemu for device tree */
     fdt = qemu_mallocz(dt_size);
 

  reply	other threads:[~2010-04-07  4:10 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-04-07  4:09 [Qemu-devel] [RFC PATCH 0/7] QEMU patches to generate FDT from qdevs Grant Likely
2010-04-07  4:10 ` Grant Likely [this message]
2010-04-09 12:00   ` [Qemu-devel] [RFC PATCH 1/7] devicetree: Add 8k instead of double dtb size when reserving extra memory Paul Brook
2010-04-09 14:55     ` Grant Likely
2010-04-07  4:10 ` [Qemu-devel] [RFC PATCH 2/7] devicetree: auto-populate the device tree with qdev data Grant Likely
2010-04-07  4:10 ` [Qemu-devel] [RFC PATCH 3/7] devicetree: add helper for determining IRQ properties in the device tree Grant Likely
2010-04-07  4:10 ` [Qemu-devel] [RFC PATCH 4/7] devicetree: Add sysbus fdt populate hooks Grant Likely
2010-04-07  4:10 ` [Qemu-devel] [RFC PATCH 5/7] devicetree: Add helper to register devices with an fdt_populate hook Grant Likely
2010-04-07  4:10 ` [Qemu-devel] [RFC PATCH 6/7] devicetree: Add fdt_populate hook to pl011 device Grant Likely
2010-04-07  4:10 ` [Qemu-devel] [RFC PATCH 7/7] devicetree: Add fdt_populate hook to smc91x device Grant Likely
2010-04-07  7:01 ` [Qemu-devel] Re: [RFC PATCH 0/7] QEMU patches to generate FDT from qdevs Jeremy Kerr
2010-04-07 20:58   ` Grant Likely
2010-04-07 19:10 ` [Qemu-devel] " Blue Swirl
2010-04-07 20:57   ` Grant Likely
2010-04-09 12:07 ` Paul Brook
2010-04-09 14:47   ` Grant Likely
2010-04-09 15:57     ` Paul Brook
2010-04-09 16:35       ` Grant Likely

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100407041002.20274.51604.stgit@angua \
    --to=grant.likely@secretlab.ca \
    --cc=devicetree-discuss@lists.ozlabs.org \
    --cc=jeremy.kerr@canonical.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).