[Qemu-devel] Re: eepro100: New patches

["Michael S. Tsirkin" <mst@redhat.com>]

On Tue, Apr 06, 2010 at 06:09:56PM +0200, Stefan Weil wrote:
> Michael S. Tsirkin schrieb:
> > On Tue, Apr 06, 2010 at 01:44:00PM +0200, Stefan Weil wrote:
> >   
> >> These patches fix two regressions (1, 9) which made eepro100 rather useless,
> >> use a simple method to handle the different device variants (2),
> >> add a new device variant (4) and fix or clean some smaller issues.
> >>
> >> [PATCH 1/9] eepro100: Don't allow writing SCBStatus
> >> [PATCH 2/9] eepro100: Simplify status handling
> >> [PATCH 3/9] eepro100: Simplified device instantiation
> >> [PATCH 4/9] eepro100: Add new device variant i82801
> >> [PATCH 5/9] eepro100: Set configuration bit for standard TCB
> >> [PATCH 6/9] eepro100: Support compilation without EEPROM
> >> [PATCH 7/9] eepro100: Set power management capability using pci_reserve_capability
> >> [PATCH 8/9] eepro100: Fix mapping of flash memory
> >> [PATCH 9/9] eepro100: Fix PCI interrupt pin configuration regression
> >>
> >> Regards,
> >> Stefan
> >>     
> >
> > I've applied these on my tree with some minor tweaks.
> > Could you please let me know whether the result looks
> > sane to you?
> >
> > Thanks!
> >   
> 
> I noticed minor tweaks in patches 2 and 8, both ok.
> 
> Regards
> Stefan


OK, I added an API to add a capability at a known offset,
eepro100 code becomes simpler if we use it.
Can you review and ack please?

-- 
MST