From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1NzQOZ-0003Tc-4y
	for qemu-devel@nongnu.org; Wed, 07 Apr 2010 04:13:55 -0400
Received: from [140.186.70.92] (port=51357 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1NzQOV-0003T1-F2
	for qemu-devel@nongnu.org; Wed, 07 Apr 2010 04:13:53 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69)
	(envelope-from <mst@redhat.com>) id 1NzQOQ-0000Ra-VY
	for qemu-devel@nongnu.org; Wed, 07 Apr 2010 04:13:51 -0400
Received: from mx1.redhat.com ([209.132.183.28]:6441)
	by eggs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <mst@redhat.com>) id 1NzQOQ-0000RS-Mz
	for qemu-devel@nongnu.org; Wed, 07 Apr 2010 04:13:46 -0400
Date: Wed, 7 Apr 2010 11:10:03 +0300
From: "Michael S. Tsirkin" <mst@redhat.com>
Message-ID: <20100407081003.GA9550@redhat.com>
References: <1270554249-24861-1-git-send-email-weil@mail.berlios.de>
	<20100406124020.GA19739@redhat.com>
	<4BBB5CD4.5080705@mail.berlios.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <4BBB5CD4.5080705@mail.berlios.de>
Subject: [Qemu-devel] Re: eepro100: New patches
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Stefan Weil <weil@mail.berlios.de>
Cc: QEMU Developers <qemu-devel@nongnu.org>

On Tue, Apr 06, 2010 at 06:09:56PM +0200, Stefan Weil wrote:
> Michael S. Tsirkin schrieb:
> > On Tue, Apr 06, 2010 at 01:44:00PM +0200, Stefan Weil wrote:
> >   
> >> These patches fix two regressions (1, 9) which made eepro100 rather useless,
> >> use a simple method to handle the different device variants (2),
> >> add a new device variant (4) and fix or clean some smaller issues.
> >>
> >> [PATCH 1/9] eepro100: Don't allow writing SCBStatus
> >> [PATCH 2/9] eepro100: Simplify status handling
> >> [PATCH 3/9] eepro100: Simplified device instantiation
> >> [PATCH 4/9] eepro100: Add new device variant i82801
> >> [PATCH 5/9] eepro100: Set configuration bit for standard TCB
> >> [PATCH 6/9] eepro100: Support compilation without EEPROM
> >> [PATCH 7/9] eepro100: Set power management capability using pci_reserve_capability
> >> [PATCH 8/9] eepro100: Fix mapping of flash memory
> >> [PATCH 9/9] eepro100: Fix PCI interrupt pin configuration regression
> >>
> >> Regards,
> >> Stefan
> >>     
> >
> > I've applied these on my tree with some minor tweaks.
> > Could you please let me know whether the result looks
> > sane to you?
> >
> > Thanks!
> >   
> 
> I noticed minor tweaks in patches 2 and 8, both ok.
> 
> Regards
> Stefan


OK, I added an API to add a capability at a known offset,
eepro100 code becomes simpler if we use it.
Can you review and ack please?

-- 
MST