From: Luiz Capitulino <lcapitulino@redhat.com>
To: Kevin Wolf <kwolf@redhat.com>
Cc: Jan Kiszka <jan.kiszka@siemens.com>,
Anthony Liguori <aliguori@us.ibm.com>,
Christoph Hellwig <hch@lst.de>,
qemu-devel <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH] virtio-blk: Fix use after release in virtio_blk_handle_rw_error
Date: Wed, 7 Apr 2010 09:32:35 -0300 [thread overview]
Message-ID: <20100407093235.08a418ad@redhat.com> (raw)
In-Reply-To: <4BBC7812.8080802@redhat.com>
On Wed, 07 Apr 2010 14:18:26 +0200
Kevin Wolf <kwolf@redhat.com> wrote:
> Am 07.04.2010 13:57, schrieb Christoph Hellwig:
> > On Wed, Apr 07, 2010 at 01:47:47PM +0200, Jan Kiszka wrote:
> >> virtio_blk_req_complete releases the request we dereference again for
> >> bdrv_mon_event. Reorder both calls to fix this.
> >
> > I think Kevin alreday sent a patch to use the local state variable
> > which is still around. Either way looks fine to me.
>
> Yes, it's the same thing, so I won't pick this up for my block branch
> even though Jan's fix looks fine, too.
I also resend Kevin's fix two days ago as part of a git pull, but
looks like Anthony is away..
next prev parent reply other threads:[~2010-04-07 12:32 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-07 11:47 [Qemu-devel] [PATCH] virtio-blk: Fix use after release in virtio_blk_handle_rw_error Jan Kiszka
2010-04-07 11:57 ` Christoph Hellwig
2010-04-07 12:18 ` Kevin Wolf
2010-04-07 12:32 ` Luiz Capitulino [this message]
2010-04-07 12:33 ` Luiz Capitulino
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100407093235.08a418ad@redhat.com \
--to=lcapitulino@redhat.com \
--cc=aliguori@us.ibm.com \
--cc=hch@lst.de \
--cc=jan.kiszka@siemens.com \
--cc=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).