From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1NzURy-0000o4-0Q
	for qemu-devel@nongnu.org; Wed, 07 Apr 2010 08:33:42 -0400
Received: from [140.186.70.92] (port=42752 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1NzURw-0000mZ-FO
	for qemu-devel@nongnu.org; Wed, 07 Apr 2010 08:33:41 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69)
	(envelope-from <lcapitulino@redhat.com>) id 1NzURv-0005aK-1V
	for qemu-devel@nongnu.org; Wed, 07 Apr 2010 08:33:40 -0400
Received: from mx1.redhat.com ([209.132.183.28]:34493)
	by eggs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <lcapitulino@redhat.com>) id 1NzURu-0005a9-Pz
	for qemu-devel@nongnu.org; Wed, 07 Apr 2010 08:33:39 -0400
Date: Wed, 7 Apr 2010 09:33:29 -0300
From: Luiz Capitulino <lcapitulino@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] virtio-blk: Fix use after release in
	virtio_blk_handle_rw_error
Message-ID: <20100407093329.50a0b874@redhat.com>
In-Reply-To: <20100407093235.08a418ad@redhat.com>
References: <4BBC70E3.6010609@siemens.com> <20100407115738.GA12452@lst.de>
	<4BBC7812.8080802@redhat.com> <20100407093235.08a418ad@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Kevin Wolf <kwolf@redhat.com>
Cc: Jan Kiszka <jan.kiszka@siemens.com>, Anthony Liguori <aliguori@us.ibm.com>, Christoph Hellwig <hch@lst.de>, qemu-devel <qemu-devel@nongnu.org>

On Wed, 7 Apr 2010 09:32:35 -0300
Luiz Capitulino <lcapitulino@redhat.com> wrote:

> On Wed, 07 Apr 2010 14:18:26 +0200
> Kevin Wolf <kwolf@redhat.com> wrote:
> 
> > Am 07.04.2010 13:57, schrieb Christoph Hellwig:
> > > On Wed, Apr 07, 2010 at 01:47:47PM +0200, Jan Kiszka wrote:
> > >> virtio_blk_req_complete releases the request we dereference again for
> > >> bdrv_mon_event. Reorder both calls to fix this.
> > > 
> > > I think Kevin alreday sent a patch to use the local state variable
> > > which is still around.  Either way looks fine to me.
> > 
> > Yes, it's the same thing, so I won't pick this up for my block branch
> > even though Jan's fix looks fine, too.
> 
>  I also resend Kevin's fix two days ago as part of a git pull, but
> looks like Anthony is away..

 A pull request, I mean.