From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1NzTtE-0001Z6-EX
	for qemu-devel@nongnu.org; Wed, 07 Apr 2010 07:57:48 -0400
Received: from [140.186.70.92] (port=50137 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1NzTt9-0001VL-9R
	for qemu-devel@nongnu.org; Wed, 07 Apr 2010 07:57:48 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69)
	(envelope-from <hch@lst.de>) id 1NzTt6-0007i4-HY
	for qemu-devel@nongnu.org; Wed, 07 Apr 2010 07:57:42 -0400
Received: from verein.lst.de ([213.95.11.210]:34886)
	by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from <hch@lst.de>)
	id 1NzTt6-0007hn-2Y
	for qemu-devel@nongnu.org; Wed, 07 Apr 2010 07:57:40 -0400
Date: Wed, 7 Apr 2010 13:57:38 +0200
From: Christoph Hellwig <hch@lst.de>
Subject: Re: [Qemu-devel] [PATCH] virtio-blk: Fix use after release in
	virtio_blk_handle_rw_error
Message-ID: <20100407115738.GA12452@lst.de>
References: <4BBC70E3.6010609@siemens.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <4BBC70E3.6010609@siemens.com>
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Jan Kiszka <jan.kiszka@siemens.com>
Cc: Anthony Liguori <aliguori@us.ibm.com>, qemu-devel <qemu-devel@nongnu.org>, Luiz Capitulino <lcapitulino@redhat.com>

On Wed, Apr 07, 2010 at 01:47:47PM +0200, Jan Kiszka wrote:
> virtio_blk_req_complete releases the request we dereference again for
> bdrv_mon_event. Reorder both calls to fix this.

I think Kevin alreday sent a patch to use the local state variable
which is still around.  Either way looks fine to me.