From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1NzpiP-0006ww-Nj
	for qemu-devel@nongnu.org; Thu, 08 Apr 2010 07:16:05 -0400
Received: from [140.186.70.92] (port=36891 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1NzpiN-0006vu-7A
	for qemu-devel@nongnu.org; Thu, 08 Apr 2010 07:16:05 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69)
	(envelope-from <aurelien@aurel32.net>) id 1NzpiL-0002at-E1
	for qemu-devel@nongnu.org; Thu, 08 Apr 2010 07:16:02 -0400
Received: from hall.aurel32.net ([88.191.82.174]:43129)
	by eggs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <aurelien@aurel32.net>) id 1NzpiL-0002ah-74
	for qemu-devel@nongnu.org; Thu, 08 Apr 2010 07:16:01 -0400
Date: Thu, 8 Apr 2010 11:58:41 +0200
From: Aurelien Jarno <aurelien@aurel32.net>
Subject: Re: [Qemu-devel] [PATCH] resource leak fixes for iwmmxt disassemble
Message-ID: <20100408095841.GD5700@volta.aurel32.net>
References: <20100315172204.GF8895@firewall>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-15
Content-Disposition: inline
In-Reply-To: <20100315172204.GF8895@firewall>
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Lars Munch <lars@segv.dk>
Cc: qemu-devel@nongnu.org

On Mon, Mar 15, 2010 at 06:22:04PM +0100, Lars Munch wrote:
> 
> This patch fixes few resource leaks in the iwmmxt disassemble.

Thanks, applied.

> Signed-off-by: Lars Munch <lars@segv.dk>
> ---
>  target-arm/translate.c |    2 ++
>  1 files changed, 2 insertions(+), 0 deletions(-)
> 
> diff --git a/target-arm/translate.c b/target-arm/translate.c
> index cdfe946..2ab7881 100644
> --- a/target-arm/translate.c
> +++ b/target-arm/translate.c
> @@ -1131,6 +1131,7 @@ static inline TCGv iwmmxt_load_creg(int reg)
>  static inline void iwmmxt_store_creg(int reg, TCGv var)
>  {
>      tcg_gen_st_i32(var, cpu_env, offsetof(CPUState, iwmmxt.cregs[reg]));
> +    dead_tmp(var);
>  }
>  
>  static inline void gen_op_iwmmxt_movq_wRn_M0(int rn)
> @@ -1415,6 +1416,7 @@ static int disas_iwmmxt_insn(CPUState *env, DisasContext *s, uint32_t insn)
>                  }
>              }
>          }
> +        dead_tmp(addr);
>          return 0;
>      }
>  
> -- 
> 1.7.0
> 
> 
> 
> 

-- 
Aurelien Jarno                          GPG: 1024D/F1BCDB73
aurelien@aurel32.net                 http://www.aurel32.net