From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1NzzdN-0004rq-Hs
	for qemu-devel@nongnu.org; Thu, 08 Apr 2010 17:51:33 -0400
Received: from [140.186.70.92] (port=57136 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1NzzdI-0004ps-ML
	for qemu-devel@nongnu.org; Thu, 08 Apr 2010 17:51:30 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69)
	(envelope-from <aurelien@aurel32.net>) id 1NzzdH-0004OA-IF
	for qemu-devel@nongnu.org; Thu, 08 Apr 2010 17:51:28 -0400
Date: Thu, 8 Apr 2010 21:17:48 +0200
From: Aurelien Jarno <aurelien@aurel32.net>
Subject: Re: [Qemu-devel] [PATCH] baum: add destroy hook
Message-ID: <20100408191748.GF6056@volta.aurel32.net>
References: <20100228200300.GD11637@const.famille.thibault.fr>
	<20100328183942.GN7497@const.famille.thibault.fr>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-15
Content-Disposition: inline
In-Reply-To: <20100328183942.GN7497@const.famille.thibault.fr>
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Samuel Thibault <samuel.thibault@gnu.org>
Cc: qemu-devel@nongnu.org

On Sun, Mar 28, 2010 at 08:39:42PM +0200, Samuel Thibault wrote:
> Hello,
> 
> This adds a destroy hook for the baum character device, to properly
> close the BrlAPI connection and free resources.
> 
> Signed-off-by: Samuel Thibault <samuel.thibault@ens-lyon.org>

Thanks, applied.

> commit 447c41758cfda0022ea6e09aaf81137b2b27b915
> Author: Samuel Thibault <samuel.thibault@ens-lyon.org>
> Date:   Sun Mar 28 20:38:38 2010 +0200
> 
>     baum: add destroy hook
>     
>     Add a destroy hook for the baum character device, to properly close the BrlAPI
>     connection.
> 
> diff --git a/hw/baum.c b/hw/baum.c
> index 18633f4..21326ae 100644
> --- a/hw/baum.c
> +++ b/hw/baum.c
> @@ -564,6 +564,18 @@ static void baum_chr_read(void *opaque)
>      }
>  }
>  
> +static void baum_close(struct CharDriverState *chr)
> +{
> +    BaumDriverState *baum = chr->opaque;
> +
> +    qemu_free_timer(baum->cellCount_timer);
> +    if (baum->brlapi) {
> +        brlapi__closeConnection(baum->brlapi);
> +        qemu_free(baum->brlapi);
> +    }
> +    qemu_free(baum);
> +}
> +
>  CharDriverState *chr_baum_init(QemuOpts *opts)
>  {
>      BaumDriverState *baum;
> @@ -581,6 +593,7 @@ CharDriverState *chr_baum_init(QemuOpts *opts)
>      chr->chr_write = baum_write;
>      chr->chr_send_event = baum_send_event;
>      chr->chr_accept_input = baum_accept_input;
> +    chr->chr_close = baum_close;
>  
>      handle = qemu_mallocz(brlapi_getHandleSize());
>      baum->brlapi = handle;
> 
> 
> 

-- 
Aurelien Jarno                          GPG: 1024D/F1BCDB73
aurelien@aurel32.net                 http://www.aurel32.net