From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1O01SZ-0003kE-Ka for qemu-devel@nongnu.org; Thu, 08 Apr 2010 19:48:31 -0400 Received: from [140.186.70.92] (port=48789 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1O01SY-0003k0-Hf for qemu-devel@nongnu.org; Thu, 08 Apr 2010 19:48:31 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1O01SX-0002zq-BX for qemu-devel@nongnu.org; Thu, 08 Apr 2010 19:48:30 -0400 Received: from mx20.gnu.org ([199.232.41.8]:34259) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1O01SX-0002zl-9q for qemu-devel@nongnu.org; Thu, 08 Apr 2010 19:48:29 -0400 Received: from mail.codesourcery.com ([38.113.113.100]) by mx20.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1O01SW-0002dt-M6 for qemu-devel@nongnu.org; Thu, 08 Apr 2010 19:48:29 -0400 From: Paul Brook Subject: Re: [Qemu-devel] [PATCH] microblaze: fix build on Ubuntu Hardy Date: Fri, 9 Apr 2010 00:48:21 +0100 References: <1270765360-5008-1-git-send-email-thomas_ml@monjalon.net> In-Reply-To: <1270765360-5008-1-git-send-email-thomas_ml@monjalon.net> MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-15" Content-Transfer-Encoding: 7bit Message-Id: <201004090048.21847.paul@codesourcery.com> List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org > { > - fprintf_ftype fprintf = info->fprintf_func; > void * stream = info->stream; I'm pretty sure this is not the correct fix. "Fix a warning" is not sufficient justification for any change. We need to understand what was wrong with the old code, and why the new code is correct. Paul