From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1O0IOC-0001wq-U5
	for qemu-devel@nongnu.org; Fri, 09 Apr 2010 13:53:08 -0400
Received: from [140.186.70.92] (port=48422 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1O0IOA-0001vr-Os
	for qemu-devel@nongnu.org; Fri, 09 Apr 2010 13:53:08 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69)
	(envelope-from <lcapitulino@redhat.com>) id 1O0IO8-0005it-NO
	for qemu-devel@nongnu.org; Fri, 09 Apr 2010 13:53:06 -0400
Received: from mx1.redhat.com ([209.132.183.28]:37971)
	by eggs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <lcapitulino@redhat.com>) id 1O0IO8-0005iZ-Fv
	for qemu-devel@nongnu.org; Fri, 09 Apr 2010 13:53:04 -0400
Date: Fri, 9 Apr 2010 14:25:54 -0300
From: Luiz Capitulino <lcapitulino@redhat.com>
Message-ID: <20100409142554.54e36521@redhat.com>
In-Reply-To: <1270757799-31891-1-git-send-email-miguel.filho@gmail.com>
References: <1270757799-31891-1-git-send-email-miguel.filho@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] Re: [PATCH 0/22] Convert do_info_network() to
	QObject/QMP
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Miguel Di Ciurcio Filho <miguel.filho@gmail.com>
Cc: qemu-devel@nongnu.org, armbru@redhat.com

On Thu,  8 Apr 2010 17:16:17 -0300
Miguel Di Ciurcio Filho <miguel.filho@gmail.com> wrote:

> The VLANClientState structure has the member info_str, a simple string that
> is filled with information about NIC devices and used on monitor calls.
> 
> There is no coherent formatting of this string by all the NIC devices, 
> making it difficult to parse and represent this information over QMP.
> 
> Patch 01 adds a new function qdict_to_qstring().
> 
> Patch 02 replaces the function qemu_nic_format_info_str by
> qemu_nic_format_info_dict, adds a new QDict member to
> VLANClientState named info_dict.
> 
> Patches 03-21 updates all devices to feed information into the new QDict.
> 
> Patch 22 converts the 'info network' monitor command to QObject, enabling QMP
> support.

 This series has a number of small things to improve, but seems the right
approach to me and in general looks very good. I'll followup individual
patches.

 Two issues:

 1. The following sequence triggers an assert()

	(qemu) netdev_add user,id=foo
	(qemu) info network

    The netdev_add command is available in my tree (see below).

 2. The last patch conflicts with patches from Markus, you can
    rebase against my tree to solve that:

	git://repo.or.cz/qemu/qmp-unstable.git