From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1O0IOJ-0001zF-3s
	for qemu-devel@nongnu.org; Fri, 09 Apr 2010 13:53:15 -0400
Received: from [140.186.70.92] (port=48461 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1O0IOH-0001yW-Og
	for qemu-devel@nongnu.org; Fri, 09 Apr 2010 13:53:14 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69)
	(envelope-from <lcapitulino@redhat.com>) id 1O0IOG-0005kW-19
	for qemu-devel@nongnu.org; Fri, 09 Apr 2010 13:53:13 -0400
Received: from mx1.redhat.com ([209.132.183.28]:10833)
	by eggs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <lcapitulino@redhat.com>) id 1O0IOF-0005kM-PN
	for qemu-devel@nongnu.org; Fri, 09 Apr 2010 13:53:11 -0400
Date: Fri, 9 Apr 2010 14:42:55 -0300
From: Luiz Capitulino <lcapitulino@redhat.com>
Message-ID: <20100409144255.33f9a1af@redhat.com>
In-Reply-To: <1270757799-31891-19-git-send-email-miguel.filho@gmail.com>
References: <1270757799-31891-1-git-send-email-miguel.filho@gmail.com>
	<1270757799-31891-19-git-send-email-miguel.filho@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] Re: [PATCH 18/22] net: slirp: replace
 qemu_format_nic_info_str by qemu_format_nic_info_dict
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Miguel Di Ciurcio Filho <miguel.filho@gmail.com>
Cc: qemu-devel@nongnu.org, armbru@redhat.com

On Thu,  8 Apr 2010 17:16:35 -0300
Miguel Di Ciurcio Filho <miguel.filho@gmail.com> wrote:

> Signed-off-by: Miguel Di Ciurcio Filho <miguel.filho@gmail.com>
> ---
>  net/slirp.c |    7 +++++--
>  1 files changed, 5 insertions(+), 2 deletions(-)
> 
> diff --git a/net/slirp.c b/net/slirp.c
> index b41c60a..4036b92 100644
> --- a/net/slirp.c
> +++ b/net/slirp.c
> @@ -32,6 +32,8 @@
>  #include "monitor.h"
>  #include "sysemu.h"
>  #include "qemu_socket.h"
> +#include "qdict.h"
> +#include "qstring.h"
>  #include "slirp/libslirp.h"
>  
>  static int get_str_sep(char *buf, int buf_size, const char **pp, int sep)
> @@ -240,8 +242,9 @@ static int net_slirp_init(VLANState *vlan, const char *model,
>  
>      nc = qemu_new_net_client(&net_slirp_info, vlan, NULL, model, name);
>  
> -    snprintf(nc->info_str, sizeof(nc->info_str),
> -             "net=%s, restricted=%c", inet_ntoa(net), restricted ? 'y' : 'n');
> +    nc->info_dict = qdict_new();
> +    qdict_put(nc->info_dict, "net", qstring_from_str(inet_ntoa(net)));
> +    qdict_put(nc->info_dict, "restricted", qstring_from_str( restricted ? "y" : "n"));

 Better to use qbool here.

>  
>      s = DO_UPCAST(SlirpState, nc, nc);
>