From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1O0cP9-0006Py-DJ
	for qemu-devel@nongnu.org; Sat, 10 Apr 2010 11:15:27 -0400
Received: from [140.186.70.92] (port=50407 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1O0cP8-0006PN-4v
	for qemu-devel@nongnu.org; Sat, 10 Apr 2010 11:15:26 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69)
	(envelope-from <aurelien@aurel32.net>) id 1O0cP6-0005jh-UK
	for qemu-devel@nongnu.org; Sat, 10 Apr 2010 11:15:26 -0400
Received: from hall.aurel32.net ([88.191.82.174]:55564)
	by eggs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <aurelien@aurel32.net>) id 1O0cP6-0005jR-PZ
	for qemu-devel@nongnu.org; Sat, 10 Apr 2010 11:15:24 -0400
Date: Sat, 10 Apr 2010 17:15:22 +0200
From: Aurelien Jarno <aurelien@aurel32.net>
Message-ID: <20100410151522.GE23683@volta.aurel32.net>
References: <1270884363-5186-1-git-send-email-weil@mail.berlios.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <1270884363-5186-1-git-send-email-weil@mail.berlios.de>
Subject: [Qemu-devel] Re: [PATCH] Avoid compiler error
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Stefan Weil <weil@mail.berlios.de>
Cc: Juergen Lock <nox@jelal.kn-bremen.de>, QEMU Developers <qemu-devel@nongnu.org>, Richard Henderson <rth@twiddle.net>

On Sat, Apr 10, 2010 at 09:26:03AM +0200, Stefan Weil wrote:
> A 32 bit cross compilation of x86_64-linux-user raises this error:
> 
>   CC    x86_64-linux-user/exec.o
> cc1: warnings being treated as errors
> exec.c: In function ‘page_init’:
> exec.c:350: error: large integer implicitly truncated to unsigned type
> 
> L1_MAP_ADDR_SPACE_BITS == 47, HOST_LONG_BITS == 32,
> so the shift operation indeed is problematic.
> 

I am not sure it is the real fix. I don't think there is a point of
having L1_MAP_ADDR_SPACE_BITS > HOST_LONG_BITS, most probably it should
be reduced to HOST_LONG_BITS if the latter is smaller, as done in system
mode.

-- 
Aurelien Jarno                          GPG: 1024D/F1BCDB73
aurelien@aurel32.net                 http://www.aurel32.net