From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1O0tO6-00032Q-C2
	for qemu-devel@nongnu.org; Sun, 11 Apr 2010 05:23:30 -0400
Received: from [140.186.70.92] (port=46053 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1O0tO4-00031Q-JI
	for qemu-devel@nongnu.org; Sun, 11 Apr 2010 05:23:29 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69)
	(envelope-from <mst@redhat.com>) id 1O0tO3-0000tO-2A
	for qemu-devel@nongnu.org; Sun, 11 Apr 2010 05:23:28 -0400
Received: from mx1.redhat.com ([209.132.183.28]:44842)
	by eggs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <mst@redhat.com>) id 1O0tO2-0000t5-MZ
	for qemu-devel@nongnu.org; Sun, 11 Apr 2010 05:23:27 -0400
Date: Sun, 11 Apr 2010 12:19:30 +0300
From: "Michael S. Tsirkin" <mst@redhat.com>
Message-ID: <20100411091930.GC7383@redhat.com>
References: <20100409102048.GD14603@valinux.co.jp>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20100409102048.GD14603@valinux.co.jp>
Subject: [Qemu-devel] Re: [PATCH] pci: fix pci_find_space()
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Isaku Yamahata <yamahata@valinux.co.jp>
Cc: qemu-devel@nongnu.org

On Fri, Apr 09, 2010 at 07:20:48PM +0900, Isaku Yamahata wrote:
> pci capability must be in PCI space.
> It can't lay in PCIe extended config space.
> 
> Cc: "Michael S. Tsirkin" <mst@redhat.com>
> Signed-off-by: Isaku Yamahata <yamahata@valinux.co.jp>

I guess the point is that we'll need another API to allocate
extended capabilities?

> ---
>  hw/pci.c |    3 +--
>  1 files changed, 1 insertions(+), 2 deletions(-)
> 
> diff --git a/hw/pci.c b/hw/pci.c
> index 2f6907b..f50568c 100644
> --- a/hw/pci.c
> +++ b/hw/pci.c
> @@ -1701,10 +1701,9 @@ PCIDevice *pci_create_simple(PCIBus *bus, int devfn, const char *name)
>  
>  static int pci_find_space(PCIDevice *pdev, uint8_t size)
>  {
> -    int config_size = pci_config_size(pdev);
>      int offset = PCI_CONFIG_HEADER_SIZE;
>      int i;
> -    for (i = PCI_CONFIG_HEADER_SIZE; i < config_size; ++i)
> +    for (i = PCI_CONFIG_HEADER_SIZE; i < PCI_CONFIG_SPACE_SIZE - size; ++i)
>          if (pdev->used[i])
>              offset = i + 1;
>          else if (i - offset + 1 == size)
> -- 
> 1.6.6.1