From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1O1oSj-00041O-7Z
	for qemu-devel@nongnu.org; Tue, 13 Apr 2010 18:20:05 -0400
Received: from [140.186.70.92] (port=37338 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1O1oSh-00040l-RM
	for qemu-devel@nongnu.org; Tue, 13 Apr 2010 18:20:04 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69)
	(envelope-from <aurelien@aurel32.net>) id 1O1oSg-0006HP-5R
	for qemu-devel@nongnu.org; Tue, 13 Apr 2010 18:20:03 -0400
Received: from hall.aurel32.net ([88.191.82.174]:40100)
	by eggs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <aurelien@aurel32.net>) id 1O1oSf-0006GO-WB
	for qemu-devel@nongnu.org; Tue, 13 Apr 2010 18:20:02 -0400
Date: Wed, 14 Apr 2010 00:19:59 +0200
From: Aurelien Jarno <aurelien@aurel32.net>
Subject: Re: [Qemu-devel] [PATCH] linux-user: do_shmdt(): Fix
	page_set_flags's 2nd arg.
Message-ID: <20100413221959.GI24116@volta.aurel32.net>
References: <201004101709.o3AH9vx8029942@smtp12.dti.ne.jp>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-15
Content-Disposition: inline
In-Reply-To: <201004101709.o3AH9vx8029942@smtp12.dti.ne.jp>
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: takasi-y@ops.dti.ne.jp
Cc: qemu-devel@nongnu.org

On Sun, Apr 11, 2010 at 02:09:57AM +0900, takasi-y@ops.dti.ne.jp wrote:
> 2nd arg of page_set_flags() should be start+size, but size.
> 
> Signed-off-by: Takashi YOSHII <takasi-y@ops.dti.ne.jp>

Thanks, applied.

> ---
>  linux-user/syscall.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/linux-user/syscall.c b/linux-user/syscall.c
> index a03e432..26c0fb4 100644
> --- a/linux-user/syscall.c
> +++ b/linux-user/syscall.c
> @@ -2752,7 +2752,7 @@ static inline abi_long do_shmdt(abi_ulong shmaddr)
>      for (i = 0; i < N_SHM_REGIONS; ++i) {
>          if (shm_regions[i].start == shmaddr) {
>              shm_regions[i].start = 0;
> -            page_set_flags(shmaddr, shm_regions[i].size, 0);
> +            page_set_flags(shmaddr, shmaddr + shm_regions[i].size, 0);
>              break;
>          }
>      }
> -- 
> 1.6.5
> 
> 
> 
> 

-- 
Aurelien Jarno                          GPG: 1024D/F1BCDB73
aurelien@aurel32.net                 http://www.aurel32.net