From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1O2C4N-0004ed-Va for qemu-devel@nongnu.org; Wed, 14 Apr 2010 19:32:32 -0400 Received: from [140.186.70.92] (port=44939 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1O2C4L-0004bI-4q for qemu-devel@nongnu.org; Wed, 14 Apr 2010 19:32:31 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1O2C4J-0006hx-Fy for qemu-devel@nongnu.org; Wed, 14 Apr 2010 19:32:29 -0400 Received: from hall.aurel32.net ([88.191.82.174]:41562) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1O2C4J-0006hT-BQ for qemu-devel@nongnu.org; Wed, 14 Apr 2010 19:32:27 -0400 Received: from aurel32 by hall.aurel32.net with local (Exim 4.69) (envelope-from ) id 1O2C49-0007Y7-DE for qemu-devel@nongnu.org; Thu, 15 Apr 2010 01:32:17 +0200 Date: Thu, 15 Apr 2010 01:32:17 +0200 From: Aurelien Jarno Message-ID: <20100414233217.GD17857@hall.aurel32.net> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Disposition: inline Sender: Aurelien Jarno Subject: [Qemu-devel] Call for help in reviewing patches (!kvm & linux-user) List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Hi all, My impression is that few persons have interest in linux-user or non-KVM targets areas, at least from the development point of view. I personally don't care about linux-user code, though I have tried to merge patches in this area anyway, as otherwise they are just bitrotting on the mailing list. On the other hand there are quite more people at least following the development in these areas, as when something is broken, you are usually told that quite quickly. The result is that most of the patches I am merging have been reviewed only by me. This is not very good from the quality point of view, more people reviewing the code, means less risk of breakage. Reviewing patches also takes a lot of time, and it is very frustrating for me to spend most of my time on QEMU merging patches, while I would also like to spend time writing QEMU code instead. Some days when I open my mail client on the QEMU folder and see a few patch series posted, I just want to close it asap. This is therefore a call for help. If you want patches to get merged more quickly, and with less risk of breakage, don't hesitate to review patches posted on the mailing list, and send your comments or an Acked-by:. This really helps when reviewing the patches. Aurelien PS: This is not directed to any person, and some persons are already doing that, but it's just not enough. -- Aurelien Jarno GPG: 1024D/F1BCDB73 aurelien@aurel32.net http://www.aurel32.net