From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1O2Ofr-0004ho-11 for qemu-devel@nongnu.org; Thu, 15 Apr 2010 09:00:03 -0400 Received: from [140.186.70.92] (port=51787 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1O2Ofo-0004gV-Uz for qemu-devel@nongnu.org; Thu, 15 Apr 2010 09:00:02 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1O2Ofj-0005GX-S3 for qemu-devel@nongnu.org; Thu, 15 Apr 2010 09:00:00 -0400 Received: from mx1.redhat.com ([209.132.183.28]:62826) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1O2Ofj-0005GJ-KH for qemu-devel@nongnu.org; Thu, 15 Apr 2010 08:59:55 -0400 Date: Thu, 15 Apr 2010 18:28:12 +0530 From: Amit Shah Subject: Re: [Qemu-devel] [PATCH v3 0/4] char: write callback, virtio-console: flow control Message-ID: <20100415125812.GA18083@amit-x200.redhat.com> References: <1271319378-9811-1-git-send-email-amit.shah@redhat.com> <201004151304.41241.paul@codesourcery.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <201004151304.41241.paul@codesourcery.com> List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paul Brook Cc: qemu-devel@nongnu.org, Gerd Hoffmann On (Thu) Apr 15 2010 [13:04:40], Paul Brook wrote: > > This series lets interested callers ask for an -EAGAIN return from the > > chardev backends (only unix and tcp sockets as of now) to implement > > their own flow control. > > As mentioned previously, I think this is a bad idea. The device has no useful > way of determining when to transmit the rest of the data. The device gets a callback which indicates the chardev is ready to accept more data. Amit