From: Paul Brook <paul@codesourcery.com>
To: qemu-devel@nongnu.org
Cc: Amit Shah <amit.shah@redhat.com>, Gerd Hoffmann <kraxel@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v3 0/4] char: write callback, virtio-console: flow control
Date: Thu, 15 Apr 2010 13:04:40 +0100 [thread overview]
Message-ID: <201004151304.41241.paul@codesourcery.com> (raw)
In-Reply-To: <1271319378-9811-1-git-send-email-amit.shah@redhat.com>
> This series lets interested callers ask for an -EAGAIN return from the
> chardev backends (only unix and tcp sockets as of now) to implement
> their own flow control.
As mentioned previously, I think this is a bad idea. The device has no useful
way of determining when to transmit the rest of the data.
What you really want is an asynchronous transmit API.
Paul
next prev parent reply other threads:[~2010-04-15 12:02 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-15 8:16 [Qemu-devel] [PATCH v3 0/4] char: write callback, virtio-console: flow control Amit Shah
2010-04-15 8:16 ` [Qemu-devel] [PATCH v3 1/4] char: Let writers know how much data was written in case of errors Amit Shah
2010-04-15 8:16 ` [Qemu-devel] [PATCH v3 2/4] char: Add ability to provide a callback when write won't return -EAGAIN Amit Shah
2010-04-15 8:16 ` [Qemu-devel] [PATCH v3 3/4] virtio-console: Factor out common init between console and generic ports Amit Shah
2010-04-15 8:16 ` [Qemu-devel] [PATCH v3 4/4] virtio-console: Throttle virtio-serial-bus if we can't consume any more guest data Amit Shah
2010-04-20 11:32 ` [Qemu-devel] [PATCH v3 2/4] char: Add ability to provide a callback when write won't return -EAGAIN Gerd Hoffmann
2010-04-20 11:44 ` Amit Shah
2010-04-20 12:28 ` Paul Brook
2010-04-20 12:39 ` Amit Shah
2010-04-20 18:59 ` Gerd Hoffmann
2010-04-15 12:04 ` Paul Brook [this message]
2010-04-15 12:58 ` [Qemu-devel] [PATCH v3 0/4] char: write callback, virtio-console: flow control Amit Shah
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201004151304.41241.paul@codesourcery.com \
--to=paul@codesourcery.com \
--cc=amit.shah@redhat.com \
--cc=kraxel@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).