From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1O2lDS-0000d8-Th for qemu-devel@nongnu.org; Fri, 16 Apr 2010 09:04:14 -0400 Received: from [140.186.70.92] (port=46907 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1O2lDN-0000cm-4x for qemu-devel@nongnu.org; Fri, 16 Apr 2010 09:04:13 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1O2lDL-0006BH-8R for qemu-devel@nongnu.org; Fri, 16 Apr 2010 09:04:08 -0400 Received: from mx1.redhat.com ([209.132.183.28]:56961) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1O2lDL-0006AY-0W for qemu-devel@nongnu.org; Fri, 16 Apr 2010 09:04:07 -0400 Date: Fri, 16 Apr 2010 18:32:19 +0530 From: Amit Shah Subject: Re: [Qemu-devel] [PATCH 2/2] virtio-console: Notify resize to the guest. Message-ID: <20100416130219.GE21268@amit-x200.redhat.com> References: <20100416114248.A001562C03A@msa106.auone-net.jp> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20100416114248.A001562C03A@msa106.auone-net.jp> List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kusanagi Kouichi Cc: qemu-devel@nongnu.org On (Fri) Apr 16 2010 [20:42:47], Kusanagi Kouichi wrote: > > Signed-off-by: Kusanagi Kouichi > --- > hw/virtio-console.c | 3 +++ > hw/virtio-serial-bus.c | 8 ++++++++ > hw/virtio-serial.h | 9 +++++++-- > 3 files changed, 18 insertions(+), 2 deletions(-) Hello, The patches look good. How did you test them? Just one comment here: > diff --git a/hw/virtio-serial-bus.c b/hw/virtio-serial-bus.c > index 17c1ec1..66891ee 100644 > --- a/hw/virtio-serial-bus.c > +++ b/hw/virtio-serial-bus.c > @@ -163,6 +163,13 @@ int virtio_serial_close(VirtIOSerialPort *port) > return 0; > } > > +void virtio_serial_resize(VirtIOSerialPort *port, int rows, int cols) Would virtio_serial_resize_console() be better, since this is only to be used for console ports? Amit