From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1O2lQb-0001eo-Rm
	for qemu-devel@nongnu.org; Fri, 16 Apr 2010 09:17:49 -0400
Received: from [140.186.70.92] (port=54752 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1O2lQZ-0001dI-Hq
	for qemu-devel@nongnu.org; Fri, 16 Apr 2010 09:17:48 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69)
	(envelope-from <berrange@redhat.com>) id 1O2lQX-0001t3-Fw
	for qemu-devel@nongnu.org; Fri, 16 Apr 2010 09:17:47 -0400
Received: from mx1.redhat.com ([209.132.183.28]:14037)
	by eggs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <berrange@redhat.com>) id 1O2lQX-0001sm-8k
	for qemu-devel@nongnu.org; Fri, 16 Apr 2010 09:17:45 -0400
Date: Fri, 16 Apr 2010 14:17:40 +0100
From: "Daniel P. Berrange" <berrange@redhat.com>
Message-ID: <20100416131740.GM5048@redhat.com>
References: <4B190919.9040602@siemens.com> <20100416110044.GC5048@redhat.com>
	<4BC84683.7050003@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <4BC84683.7050003@redhat.com>
Subject: [Qemu-devel] Re: [FOR 0.12][PATCH] monitor: Accept input only
	byte-wise
Reply-To: "Daniel P. Berrange" <berrange@redhat.com>
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: Jan Kiszka <jan.kiszka@siemens.com>, Anthony Liguori <aliguori@us.ibm.com>, qemu-devel <qemu-devel@nongnu.org>

On Fri, Apr 16, 2010 at 01:14:11PM +0200, Paolo Bonzini wrote:
> 
> >The QEMU code appears to be written to assume that it will recvmsg() a
> >complete monitor command in one go + process that, because it closes the
> >FD the moment the data from any recvmsg() is dealt with.
> 
> This is buggy anyway.  This should fix it too:

Yep, this makes it work too, but if a client is evil they could
pass a FD to qemu with any other non-getfd command & it'd remain 
open for ever. Probably not important though.

Daniel
-- 
|: Red Hat, Engineering, London    -o-   http://people.redhat.com/berrange/ :|
|: http://libvirt.org -o- http://virt-manager.org -o- http://deltacloud.org :|
|: http://autobuild.org        -o-         http://search.cpan.org/~danberr/ :|
|: GnuPG: 7D3B9505  -o-   F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|