From: Christoph Hellwig <hch@lst.de>
To: Stefan Hajnoczi <stefanha@gmail.com>
Cc: Jan Kiszka <jan.kiszka@siemens.com>, qemu-devel <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] Guest latency issues due to bdrv_check_byte_request
Date: Sat, 17 Apr 2010 21:40:09 +0200 [thread overview]
Message-ID: <20100417194009.GA13862@lst.de> (raw)
In-Reply-To: <h2gfbd9d3991004171205q6aab7757kf4ad237821ba22f@mail.gmail.com>
On Sat, Apr 17, 2010 at 08:05:45PM +0100, Stefan Hajnoczi wrote:
> I think there are still a lot of lseeks left because
> raw-posix.c:raw_pread_aligned() is implemented using lseek+read
> instead of pread. Does anyone know the reasoning there or could
> pread() be used?
There's no good reason for it except maybe compatiblity to really
olh hosts that do not have pread/pwrite. But given that AIO support
is now mandator and the AIO code uses pread/pwritev exclusively we
would have noticed if that's the case by now.
next prev parent reply other threads:[~2010-04-17 19:40 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-15 18:15 [Qemu-devel] Guest latency issues due to bdrv_check_byte_request Jan Kiszka
2010-04-17 19:05 ` Stefan Hajnoczi
2010-04-17 19:40 ` Christoph Hellwig [this message]
2010-04-17 21:32 ` Stefan Hajnoczi
2010-04-18 17:37 ` Christoph Hellwig
2010-04-18 18:05 ` [Qemu-devel] " Jan Kiszka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100417194009.GA13862@lst.de \
--to=hch@lst.de \
--cc=jan.kiszka@siemens.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).