From: Jamie Lokier <jamie@shareable.org>
To: Benjamin Drung <bdrung@ubuntu.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] wrong behaviour of caps lock
Date: Mon, 19 Apr 2010 02:23:26 +0100 [thread overview]
Message-ID: <20100419012326.GF18876@shareable.org> (raw)
In-Reply-To: <1270224121.12075.6.camel@deep-thought>
Benjamin Drung wrote:
> - /* SDL does not send the key up event, so we generate it */
Was the original comment just plain wrong?
> - kbd_put_keycode(keycode);
> - kbd_put_keycode(keycode | 0x80);
> + if (ev->type == SDL_KEYUP) {
> + kbd_put_keycode(keycode | 0x80);
> + } else {
> + kbd_put_keycode(keycode);
> + }
The patch implies that SDL *does* send the key up event.
Somebody obviously thought that it doesn't, hence the comment.
So what has changed? Is it different versions of SDL, or does the
patch only work on some hosts / distros?
-- Jamie
next prev parent reply other threads:[~2010-04-19 1:23 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-02 16:02 [Qemu-devel] wrong behaviour of caps lock Benjamin Drung
2010-04-17 9:59 ` Stefan Weil
2010-04-19 1:23 ` Jamie Lokier [this message]
2010-04-19 8:38 ` Kevin Wolf
2010-04-19 16:07 ` Stefan Weil
2010-11-18 23:58 ` Benjamin Drung
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100419012326.GF18876@shareable.org \
--to=jamie@shareable.org \
--cc=bdrung@ubuntu.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).