From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1O3fi7-0000Ci-Ev
	for qemu-devel@nongnu.org; Sun, 18 Apr 2010 21:23:39 -0400
Received: from [140.186.70.92] (port=43459 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1O3fi5-0000Aq-Ma
	for qemu-devel@nongnu.org; Sun, 18 Apr 2010 21:23:38 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69)
	(envelope-from <jamie@shareable.org>) id 1O3fi3-0007VR-Hr
	for qemu-devel@nongnu.org; Sun, 18 Apr 2010 21:23:37 -0400
Received: from mail2.shareable.org ([80.68.89.115]:43562)
	by eggs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <jamie@shareable.org>) id 1O3fi3-0007Ts-Bj
	for qemu-devel@nongnu.org; Sun, 18 Apr 2010 21:23:35 -0400
Date: Mon, 19 Apr 2010 02:23:26 +0100
From: Jamie Lokier <jamie@shareable.org>
Subject: Re: [Qemu-devel] wrong behaviour of caps lock
Message-ID: <20100419012326.GF18876@shareable.org>
References: <1270224121.12075.6.camel@deep-thought>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1270224121.12075.6.camel@deep-thought>
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Benjamin Drung <bdrung@ubuntu.com>
Cc: qemu-devel@nongnu.org

Benjamin Drung wrote:
> -        /* SDL does not send the key up event, so we generate it */

Was the original comment just plain wrong?

> -        kbd_put_keycode(keycode);
> -        kbd_put_keycode(keycode | 0x80);
> +        if (ev->type == SDL_KEYUP) {
> +            kbd_put_keycode(keycode | 0x80);
> +        } else {
> +            kbd_put_keycode(keycode);
> +        }

The patch implies that SDL *does* send the key up event.

Somebody obviously thought that it doesn't, hence the comment.

So what has changed?  Is it different versions of SDL, or does the
patch only work on some hosts / distros?

-- Jamie